From patchwork Thu Sep 6 10:47:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 182140 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D2B3B2C008B for ; Thu, 6 Sep 2012 20:47:17 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758237Ab2IFKrQ (ORCPT ); Thu, 6 Sep 2012 06:47:16 -0400 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:41305 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758228Ab2IFKrP (ORCPT ); Thu, 6 Sep 2012 06:47:15 -0400 Received: from jdelvare.pck.nerim.net ([62.212.121.182] helo=endymion.delvare) by services.gcu-squad.org (GCU Mailer Daemon) with esmtpsa id 1T9Zc8-0000x9-KG (TLSv1:AES128-SHA:128) (envelope-from ) for netdev@vger.kernel.org; Thu, 06 Sep 2012 12:47:12 +0200 Date: Thu, 6 Sep 2012 12:47:05 +0200 From: Jean Delvare To: netdev@vger.kernel.org Subject: |PATCH] seeq: Add missing spinlock init Message-ID: <20120906124705.2631ae01@endymion.delvare> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It doesn't seem this spinlock was properly initialized. Signed-off-by: Jean Delvare --- I can't even build-test this. drivers/net/ethernet/seeq/sgiseeq.c | 1 + 1 file changed, 1 insertion(+) --- linux-3.6-rc4.orig/drivers/net/ethernet/seeq/sgiseeq.c 2012-07-21 22:58:29.000000000 +0200 +++ linux-3.6-rc4/drivers/net/ethernet/seeq/sgiseeq.c 2012-09-06 12:40:30.092144722 +0200 @@ -751,6 +751,7 @@ static int __devinit sgiseeq_probe(struc sp->srings = sr; sp->rx_desc = sp->srings->rxvector; sp->tx_desc = sp->srings->txvector; + spin_lock_init(&sp->tx_lock); /* A couple calculations now, saves many cycles later. */ setup_rx_ring(dev, sp->rx_desc, SEEQ_RX_BUFFERS);