Patchwork |PATCH] seeq: Add missing spinlock init

login
register
mail settings
Submitter Jean Delvare
Date Sept. 6, 2012, 10:47 a.m.
Message ID <20120906124705.2631ae01@endymion.delvare>
Download mbox | patch
Permalink /patch/182140/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jean Delvare - Sept. 6, 2012, 10:47 a.m.
It doesn't seem this spinlock was properly initialized.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
I can't even build-test this.

 drivers/net/ethernet/seeq/sgiseeq.c |    1 +
 1 file changed, 1 insertion(+)
David Miller - Sept. 7, 2012, 4:59 p.m.
From: Jean Delvare <khali@linux-fr.org>
Date: Thu, 6 Sep 2012 12:47:05 +0200

> It doesn't seem this spinlock was properly initialized.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-3.6-rc4.orig/drivers/net/ethernet/seeq/sgiseeq.c	2012-07-21 22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/net/ethernet/seeq/sgiseeq.c	2012-09-06 12:40:30.092144722 +0200
@@ -751,6 +751,7 @@  static int __devinit sgiseeq_probe(struc
 	sp->srings = sr;
 	sp->rx_desc = sp->srings->rxvector;
 	sp->tx_desc = sp->srings->txvector;
+	spin_lock_init(&sp->tx_lock);
 
 	/* A couple calculations now, saves many cycles later. */
 	setup_rx_ring(dev, sp->rx_desc, SEEQ_RX_BUFFERS);