Message ID | 50485BEA.1080401@canonical.com |
---|---|
State | New |
Headers | show |
On 09/06/2012 02:16 AM, David Henningsson wrote:
> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports
David - all of these patches look like good bug fixes. Why not submit
them via stable? But first, you ought to actually build them first.
/home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:
In function 'alc269_fixup_inv_dmic':
/home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:5848:3:
error: implicit declaration of function 'alc_add_inv_dmic_mixer'
[-Werror=implicit-function-declaration]
CC [M] drivers/media/dvb/frontends/drxk_hard.o
cc1: some warnings being treated as errors
make[5]: *** [sound/pci/hda/patch_realtek.o] Error 1
rtg
On 09/06/2012 02:35 PM, Tim Gardner wrote: > On 09/06/2012 02:16 AM, David Henningsson wrote: >> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports > > David - all of these patches look like good bug fixes. Why not submit > them via stable? One of them are indeed submitted to stable as well, but you never know how long that takes, and so I figured it would be good to get them in before quantal starts going into different kinds of freezes. For the others - they are either not strictly regressions (e g the phantom jack patch), or slightly too big (e g "Support single 3-pin jack without VREF"), and for a few, well, maybe they should have been sent to stable. > But first, you ought to actually build them first. > > /home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c: > In function 'alc269_fixup_inv_dmic': > /home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:5848:3: > error: implicit declaration of function 'alc_add_inv_dmic_mixer' Sorry, fixed now by adding a patch that the affected patch depends on. New tree pushed.
On 09/06/2012 07:18 AM, David Henningsson wrote: > On 09/06/2012 02:35 PM, Tim Gardner wrote: >> On 09/06/2012 02:16 AM, David Henningsson wrote: >>> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports >> >> David - all of these patches look like good bug fixes. Why not submit >> them via stable? > > One of them are indeed submitted to stable as well, but you never know > how long that takes, and so I figured it would be good to get them in > before quantal starts going into different kinds of freezes. > For the others - they are either not strictly regressions (e g the > phantom jack patch), or slightly too big (e g "Support single 3-pin jack > without VREF"), and for a few, well, maybe they should have been sent to > stable. Its not strictly required that a stable patch fix a regression. I'm certain that the stable maintainers are quite happy to take patches that fix bugs as well, which all of these patches appear to do. rtg