Patchwork [Quantal,PULL,REQUEST] Sound backport patches

login
register
mail settings
Submitter David Henningsson
Date Sept. 6, 2012, 8:16 a.m.
Message ID <50485BEA.1080401@canonical.com>
Download mbox
Permalink /patch/182074/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports

Comments

David Henningsson - Sept. 6, 2012, 8:16 a.m.
So, I went through those of my patches that were in upstream but not in 
quantal, and came up with the following list which I would like to see 
in quantal as well. See Patch justification below for an overview of 
what the patches do.

===========================
Pull request
===========================

The following changes since commit 1b3ff8d95da2f98502572e2ae61ce43a9c207e43:

   UBUNTU: Ubuntu-3.5.0-13.14 (2012-08-29 10:20:11 -0600)

are available in the git repository at:

   git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports

for you to fetch changes up to 134be8603f9c83246005a5c42ee136463cde18d4:

   ALSA: hda - Don't send invalid volume knob command on IDT 92hd75bxx 
(2012-09-06 01:54:59 +0200)

----------------------------------------------------------------
David Henningsson (9):
       ALSA: HDA: Create phantom jacks for fixed inputs and outputs
       ALSA: HDA: Support single 3-pin jack without VREF on the actual pin
       ALSA: hda - give 3-pin jack the name "Headphone Mic Jack"
       ALSA: hda - Do not set GPIOs for speakers on IDT if there are no 
speakers
       ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V
       ALSA: hda - Always call standard unsolicited event for Realtek codecs
       ALSA: hda - Add inverted mic quirks for Asus U41SV, Acer 1810TZ 
and AOD260
       ALSA: hda - don't create dysfunctional mixer controls for ca0132
       ALSA: hda - Don't send invalid volume knob command on IDT 92hd75bxx

  sound/pci/hda/hda_jack.c       |   59 ++++++++++++++-------
  sound/pci/hda/hda_jack.h       |    1 +
  sound/pci/hda/patch_ca0132.c   |    8 +++
  sound/pci/hda/patch_realtek.c  |  110 
+++++++++++++++++++++++++++-------------
  sound/pci/hda/patch_sigmatel.c |   12 +++--
  sound/pci/hda/patch_via.c      |    8 +++
  6 files changed, 141 insertions(+), 57 deletions(-)

=====================
Patch justification
=====================

commit 950a693f086ec15a4debb67e76729abba4be1843
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: HDA: Create phantom jacks for fixed inputs and outputs

  - The long-term fix for bug 946232. Since that bug affects a lot of 
machines, I would really like to have it working in 12.10 / 12.04.2.



commit 134be8603f9c83246005a5c42ee136463cde18d4
Author: David Henningsson <david.henningsson@canonical.com>
     ALSA: hda - Don't send invalid volume knob command on IDT 92hd75bxx

  - This one is more janitorial, not strictly necessary. Likely the 
codec ignores invalid verbs sent to it. But removes an error from the 
test suite.



commit cec383070717a3297ec39decb7e1217358feccac
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - Always call standard unsolicited event for Realtek codecs

commit 41a67001b500589999f2f759beaafd1207bd496c
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - Fix pop noise in headphones on S3 for Asus X55A, X55V

commit 1d8c12a353b0bc4fe5a8d9d709037e503639447d
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - Do not set GPIOs for speakers on IDT if there are no 
speakers

commit 8d0789af1977f5886c7e6131a0b7099174c7fd22
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - give 3-pin jack the name "Headphone Mic Jack"

commit 4b2fbb48291a190314f9872ac7359979e134e29d
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: HDA: Support single 3-pin jack without VREF on the actual pin

  - All of the above are hardware enablement fixes, necessary if we want 
to certify certain hardware in 12.10 / 12.04.2.



commit 24a5ab3458d1884f7d7e563367c16c74d45b189f
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - don't create dysfunctional mixer controls for ca0132

commit 573100f22d49c82f7896e3694f96ff374eaf332b
Author: David Henningsson <david.henningsson@canonical.com>

     ALSA: hda - Add inverted mic quirks for Asus U41SV, Acer 1810TZ and 
AOD260

  - These two are distro bugfixes.
Tim Gardner - Sept. 6, 2012, 12:35 p.m.
On 09/06/2012 02:16 AM, David Henningsson wrote:
> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports

David - all of these patches look like good bug fixes. Why not submit
them via stable? But first, you ought to actually build them first.

/home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:
In function 'alc269_fixup_inv_dmic':
/home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:5848:3:
error: implicit declaration of function 'alc_add_inv_dmic_mixer'
[-Werror=implicit-function-declaration]
  CC [M]  drivers/media/dvb/frontends/drxk_hard.o
cc1: some warnings being treated as errors
make[5]: *** [sound/pci/hda/patch_realtek.o] Error 1

rtg
David Henningsson - Sept. 6, 2012, 1:18 p.m.
On 09/06/2012 02:35 PM, Tim Gardner wrote:
> On 09/06/2012 02:16 AM, David Henningsson wrote:
>> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports
>
> David - all of these patches look like good bug fixes. Why not submit
> them via stable?

One of them are indeed submitted to stable as well, but you never know 
how long that takes, and so I figured it would be good to get them in 
before quantal starts going into different kinds of freezes.
For the others - they are either not strictly regressions (e g the 
phantom jack patch), or slightly too big (e g "Support single 3-pin jack 
without VREF"), and for a few, well, maybe they should have been sent to 
stable.

> But first, you ought to actually build them first.
>
> /home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:
> In function 'alc269_fixup_inv_dmic':
> /home/rtg/ukb/quantal/amd64/master-next/ubuntu-quantal/sound/pci/hda/patch_realtek.c:5848:3:
> error: implicit declaration of function 'alc_add_inv_dmic_mixer'

Sorry, fixed now by adding a patch that the affected patch depends on. 
New tree pushed.
Tim Gardner - Sept. 6, 2012, 2:18 p.m.
On 09/06/2012 07:18 AM, David Henningsson wrote:
> On 09/06/2012 02:35 PM, Tim Gardner wrote:
>> On 09/06/2012 02:16 AM, David Henningsson wrote:
>>> git://kernel.ubuntu.com/diwic/ubuntu-quantal.git sound-backports
>>
>> David - all of these patches look like good bug fixes. Why not submit
>> them via stable?
> 
> One of them are indeed submitted to stable as well, but you never know
> how long that takes, and so I figured it would be good to get them in
> before quantal starts going into different kinds of freezes.
> For the others - they are either not strictly regressions (e g the
> phantom jack patch), or slightly too big (e g "Support single 3-pin jack
> without VREF"), and for a few, well, maybe they should have been sent to
> stable.

Its not strictly required that a stable patch fix a regression. I'm
certain that the stable maintainers are quite happy to take patches that
fix bugs as well, which all of these patches appear to do.

rtg