From patchwork Wed Sep 5 14:35:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 181880 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 496C82C0089 for ; Thu, 6 Sep 2012 00:37:09 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9Ghy-0001aC-7z; Wed, 05 Sep 2012 14:35:58 +0000 Received: from mail-gg0-f177.google.com ([209.85.161.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9Ghv-0001Zf-L9 for linux-mtd@lists.infradead.org; Wed, 05 Sep 2012 14:35:56 +0000 Received: by ggnm2 with SMTP id m2so91196ggn.36 for ; Wed, 05 Sep 2012 07:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=LBJx7eUhjzLdvK/rpal674eJ7L7r9bOOtZ9br0Vx+sU=; b=dKV+r62T8oAC8ZjJDgqO9FGE8ujzMsgO6g/hOP+g6xw/3BL1pxyUke+xzxYSnfRqLH +/XAmT4v4Ow2fqfRmrTrKQU7Ek/muLUaft6AfJqu99oVaRh7gaiOVBNNJgga3+gGjxgc hBNHWLCLS4DpovoORR3paGCyMeDjT8BUYGi0E5jcmo1ewitZpZUukqiprZKTkbd+JxA5 y+s9JNpz00k2hj6Z/P11XE3v7Kp4oawhBE4mz9BlHq8K0ExNjIQ6lgTs/XYh7aGPtct1 xodRh9Do5S/v+jJnYP5lJkBFe+MeK6XkCPuwftSpGCwd55GsFy5q82ONxTPOrebh8sJo WdXg== Received: by 10.236.186.101 with SMTP id v65mr23281643yhm.23.1346855754269; Wed, 05 Sep 2012 07:35:54 -0700 (PDT) Received: from fabio-Latitude-E6410.cps.virtua.com.br ([201.82.136.222]) by mx.google.com with ESMTPS id j9sm1843130anl.4.2012.09.05.07.35.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Sep 2012 07:35:52 -0700 (PDT) From: Fabio Estevam To: artem.bityutskiy@linux.intel.com Subject: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Date: Wed, 5 Sep 2012 11:35:24 -0300 Message-Id: <1346855725-31726-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.161.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: marex@denx.de, b32955@freescale.com, linux-mtd@lists.infradead.org, Fabio Estevam , kernel@pengutronix.de X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Fabio Estevam Using module_platform_driver() makes the code smaller and cleaner. Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut Reviewed-by: Marek Vasut --- This patch depends on: "mtd: gpmi-nand: Improve logging style" drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 9493507..5999b15 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -1651,6 +1651,8 @@ static int __devinit gpmi_nand_probe(struct platform_device *pdev) if (ret) goto exit_nfc_init; + dev_info(this->dev, "driver registered.\n"); + return 0; exit_nfc_init: @@ -1658,10 +1660,12 @@ exit_nfc_init: exit_acquire_resources: platform_set_drvdata(pdev, NULL); kfree(this); + dev_err(this->dev, "driver registration failed: %d\n", ret); + return ret; } -static int __exit gpmi_nand_remove(struct platform_device *pdev) +static int __devexit gpmi_nand_remove(struct platform_device *pdev) { struct gpmi_nand_data *this = platform_get_drvdata(pdev); @@ -1678,29 +1682,10 @@ static struct platform_driver gpmi_nand_driver = { .of_match_table = gpmi_nand_id_table, }, .probe = gpmi_nand_probe, - .remove = __exit_p(gpmi_nand_remove), + .remove = __devexit_p(gpmi_nand_remove), .id_table = gpmi_ids, }; - -static int __init gpmi_nand_init(void) -{ - int err; - - err = platform_driver_register(&gpmi_nand_driver); - if (err == 0) - pr_info("driver registered.\n"); - else - pr_err("driver registration failed.\n"); - return err; -} - -static void __exit gpmi_nand_exit(void) -{ - platform_driver_unregister(&gpmi_nand_driver); -} - -module_init(gpmi_nand_init); -module_exit(gpmi_nand_exit); +module_platform_driver(gpmi_nand_driver); MODULE_AUTHOR("Freescale Semiconductor, Inc."); MODULE_DESCRIPTION("i.MX GPMI NAND Flash Controller Driver");