| Message ID | 1346851653-28117-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3d10095a941a29253102625d8710fe31a1a24b56 |
| Headers | show |
于 2012年09月05日 21:27, Fabio Estevam 写道: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Improve logging style by prefixing the pr_ messages with "gpmi_nand". > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index c46be6c..9493507 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -18,6 +18,9 @@ > * with this program; if not, write to the Free Software Foundation, Inc., > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include <linux/clk.h> > #include <linux/slab.h> > #include <linux/interrupt.h> > @@ -114,7 +117,7 @@ int common_nfc_set_geometry(struct gpmi_nand_data *this) > /* We use the same ECC strength for all chunks. */ > geo->ecc_strength = get_ecc_strength(this); > if (!geo->ecc_strength) { > - pr_err("We get a wrong ECC strength.\n"); > + pr_err("wrong ECC strength.\n"); > return -EINVAL; > } > > @@ -1685,9 +1688,9 @@ static int __init gpmi_nand_init(void) > > err = platform_driver_register(&gpmi_nand_driver); > if (err == 0) > - printk(KERN_INFO "GPMI NAND driver registered. (IMX)\n"); > + pr_info("driver registered.\n"); > else > - pr_err("i.MX GPMI NAND driver registration failed\n"); > + pr_err("driver registration failed.\n"); > return err; > } > thanks. Acked-by: Huang Shijie <b32955@freescale.com> Huang Shijie
On Wed, 2012-09-05 at 10:27 -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Improve logging style by prefixing the pr_ messages with "gpmi_nand". > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index c46be6c..9493507 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -18,6 +18,9 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/clk.h> #include <linux/slab.h> #include <linux/interrupt.h> @@ -114,7 +117,7 @@ int common_nfc_set_geometry(struct gpmi_nand_data *this) /* We use the same ECC strength for all chunks. */ geo->ecc_strength = get_ecc_strength(this); if (!geo->ecc_strength) { - pr_err("We get a wrong ECC strength.\n"); + pr_err("wrong ECC strength.\n"); return -EINVAL; } @@ -1685,9 +1688,9 @@ static int __init gpmi_nand_init(void) err = platform_driver_register(&gpmi_nand_driver); if (err == 0) - printk(KERN_INFO "GPMI NAND driver registered. (IMX)\n"); + pr_info("driver registered.\n"); else - pr_err("i.MX GPMI NAND driver registration failed\n"); + pr_err("driver registration failed.\n"); return err; }