Patchwork [-tip] socket.h: extern's make no sense in userspace

login
register
mail settings
Submitter Jaswinder Singh
Date Jan. 13, 2009, 8:20 a.m.
Message ID <1231834855.3212.35.camel@jaswinder.satnam>
Download mbox | patch
Permalink /patch/18185/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jaswinder Singh - Jan. 13, 2009, 8:20 a.m.
Impact: fix 2 make headers_check warnings:

usr/include/linux/socket.h:27: leaks CONFIG_PROC to userspace where it is not valid
usr/include/linux/socket.h:29: extern's make no sense in userspace

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
 include/linux/socket.h |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

Patch

diff --git a/include/linux/socket.h b/include/linux/socket.h
index 20fc4bb..f5771a2 100644
--- a/include/linux/socket.h
+++ b/include/linux/socket.h
@@ -24,11 +24,6 @@  struct __kernel_sockaddr_storage {
 #include <linux/types.h>		/* pid_t			*/
 #include <linux/compiler.h>		/* __user			*/
 
-#ifdef CONFIG_PROC_FS
-struct seq_file;
-extern void socket_seq_show(struct seq_file *seq);
-#endif
-
 typedef unsigned short	sa_family_t;
 
 /*
@@ -303,6 +298,11 @@  struct ucred {
 #define IPX_TYPE	1
 
 #ifdef __KERNEL__
+#ifdef CONFIG_PROC_FS
+struct seq_file;
+extern void socket_seq_show(struct seq_file *seq);
+#endif
+
 extern int memcpy_fromiovec(unsigned char *kdata, struct iovec *iov, int len);
 extern int memcpy_fromiovecend(unsigned char *kdata, struct iovec *iov, 
 				int offset, int len);