From patchwork Tue Jan 13 07:20:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaswinder Singh X-Patchwork-Id: 18178 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 79A40DE2F0 for ; Tue, 13 Jan 2009 18:23:19 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbZAMHXM (ORCPT ); Tue, 13 Jan 2009 02:23:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752481AbZAMHXL (ORCPT ); Tue, 13 Jan 2009 02:23:11 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:52918 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757550AbZAMHXJ (ORCPT ); Tue, 13 Jan 2009 02:23:09 -0500 Received: from [59.180.49.31] (helo=[192.168.1.200]) by bombadil.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1LMdbT-00025F-5A; Tue, 13 Jan 2009 07:22:25 +0000 Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace From: Jaswinder Singh Rajput To: Sam Ravnborg Cc: Ingo Molnar , harvey.harrison@gmail.com, gorcunov@gmail.com, roque@di.fc.ul.pt, LKML , netdev In-Reply-To: <20090113071513.GB20036@uranus.ravnborg.org> References: <1231829859.3212.19.camel@jaswinder.satnam> <20090113071513.GB20036@uranus.ravnborg.org> Date: Tue, 13 Jan 2009 12:50:03 +0530 Message-Id: <1231831203.3212.21.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2009-01-13 at 08:15 +0100, Sam Ravnborg wrote: > On Tue, Jan 13, 2009 at 12:27:39PM +0530, Jaswinder Singh Rajput wrote: > > Impact: fix 2 make headers_check warnings: > > > > usr/include/linux/in6.h:47: extern's make no sense in userspace > > usr/include/linux/in6.h:49: extern's make no sense in userspace > > > > Signed-off-by: Jaswinder Singh Rajput > > --- > > include/linux/in6.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/in6.h b/include/linux/in6.h > > index bc49204..718bf21 100644 > > --- a/include/linux/in6.h > > +++ b/include/linux/in6.h > > @@ -44,11 +44,11 @@ struct in6_addr > > * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined > > * in network byte order, not in host byte order as are the IPv4 equivalents > > */ > > +#ifdef __KERNEL__ > > extern const struct in6_addr in6addr_any; > > #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } } > > extern const struct in6_addr in6addr_loopback; > > #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } } > > -#ifdef __KERNEL__ > > It looks wrong what IN6ADDR_ANY_INIT should be a kernel only symbol. > At least google had some hits on that symbol. > > netdev people should know.... > OK, I do not want any conflicts and I want to stay in safe side ;-) Subject: [PATCH] in6.h: extern's make no sense in userspace Impact: fix 2 make headers_check warnings: usr/include/linux/in6.h:47: extern's make no sense in userspace usr/include/linux/in6.h:49: extern's make no sense in userspace Signed-off-by: Jaswinder Singh Rajput --- include/linux/in6.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/in6.h b/include/linux/in6.h index bc49204..44d921c 100644 --- a/include/linux/in6.h +++ b/include/linux/in6.h @@ -44,11 +44,11 @@ struct in6_addr * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined * in network byte order, not in host byte order as are the IPv4 equivalents */ -extern const struct in6_addr in6addr_any; #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } } -extern const struct in6_addr in6addr_loopback; #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } } #ifdef __KERNEL__ +extern const struct in6_addr in6addr_any; +extern const struct in6_addr in6addr_loopback; extern const struct in6_addr in6addr_linklocal_allnodes; #define IN6ADDR_LINKLOCAL_ALLNODES_INIT \ { { { 0xff,2,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } }