Patchwork net: don't allow INET to be not configured

login
register
mail settings
Submitter stephen hemminger
Date Sept. 4, 2012, 5:44 p.m.
Message ID <20120904104451.29819808@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/181643/
State Rejected
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Sept. 4, 2012, 5:44 p.m.
There is no reason to expose turning off TCP/IP networking.
If networking is enabled force TCP/IP to enabled. This also
eliminates the time chasing down errors with bogus configurations
generated by 'make randconfig'

For testing, it is still possible to edit Kconfig

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Sept. 4, 2012, 6:07 p.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 4 Sep 2012 10:44:51 -0700

> There is no reason to expose turning off TCP/IP networking.
> If networking is enabled force TCP/IP to enabled. This also
> eliminates the time chasing down errors with bogus configurations
> generated by 'make randconfig'
> 
> For testing, it is still possible to edit Kconfig
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

People have legitimate reasons to enable NET without INET, so let's
just fix the dependency bugs as they are reported.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/Kconfig	2012-08-15 08:59:22.910704705 -0700
+++ b/net/Kconfig	2012-09-04 10:39:53.654585718 -0700
@@ -51,26 +51,7 @@  source "net/xfrm/Kconfig"
 source "net/iucv/Kconfig"
 
 config INET
-	bool "TCP/IP networking"
-	---help---
-	  These are the protocols used on the Internet and on most local
-	  Ethernets. It is highly recommended to say Y here (this will enlarge
-	  your kernel by about 400 KB), since some programs (e.g. the X window
-	  system) use TCP/IP even if your machine is not connected to any
-	  other computer. You will get the so-called loopback device which
-	  allows you to ping yourself (great fun, that!).
-
-	  For an excellent introduction to Linux networking, please read the
-	  Linux Networking HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>.
-
-	  If you say Y here and also to "/proc file system support" and
-	  "Sysctl support" below, you can change various aspects of the
-	  behavior of the TCP/IP code by writing to the (virtual) files in
-	  /proc/sys/net/ipv4/*; the options are explained in the file
-	  <file:Documentation/networking/ip-sysctl.txt>.
-
-	  Short answer: say Y.
+	def_bool y
 
 if INET
 source "net/ipv4/Kconfig"