Patchwork [U-Boot,v3,1/2] i2c:soft:multi: Support for multiple soft I2C buses at Samsung boards

login
register
mail settings
Submitter Łukasz Majewski
Date Sept. 3, 2012, 3:58 p.m.
Message ID <1346687902-5979-2-git-send-email-l.majewski@samsung.com>
Download mbox | patch
Permalink /patch/181380/
State Superseded
Delegated to: Heiko Schocher
Headers show

Comments

Łukasz Majewski - Sept. 3, 2012, 3:58 p.m.
Support for multiple soft I2C buses.

The goal is achieved by defining get_multi_{sda|scl}_pin
functions to switch between multiple "soft" I2C buses.

Common definition of I2C_{0|1} I2C buses is provided at <i2c.h>.

TEST HW:
     Samsung's Exynos4210 evt.0.1 - Trats development board

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Minkyu Kang <mk7.kang@samsung.com>

---
Changes for v2:
- Common Samsung code has been put to board/samsung/common/multi_i2c.c file
- I2C_{4|5} have been renamed to I2C_{0|1}
- *soft_i2c_name[] table has been removed
Changes for v3:
- None

---
 board/samsung/common/Makefile    |   43 +++++++++++++++++++++++++++++
 board/samsung/common/multi_i2c.c |   55 ++++++++++++++++++++++++++++++++++++++
 include/i2c.h                    |   11 +++++++
 3 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/common/Makefile
 create mode 100644 board/samsung/common/multi_i2c.c
Łukasz Majewski - Sept. 4, 2012, 8:23 a.m.
Hi Heiko,

> Common definition of I2C_{0|1} I2C buses is provided at <i2c.h>.

> +/* Multi I2C busses handling */
> +#ifdef CONFIG_SOFT_I2C_MULTI_BUS
> +enum {
> +	I2C_0,
> +	I2C_1,
> +};
> +

I've got a second thought about this numbering.
In the case of Trats:

I2C_0 in reality is I2C_5 (this from schematic/chip numbergin) and I2C_1
is I2C_9.

This numbering (I2C_5 and I2C_9) was proposed for v2 of this patch.

I will prepare v4 of this patch with a palatable I2C numbering solution.

Patch

diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
new file mode 100644
index 0000000..0bcd594
--- /dev/null
+++ b/board/samsung/common/Makefile
@@ -0,0 +1,43 @@ 
+#
+# Copyright (C) 2012 Samsung Electronics
+# Lukasz Majewski <l.majewski@samsung.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)libsamsung.o
+
+COBJS-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
+
+SRCS    := $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS-y))
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/samsung/common/multi_i2c.c b/board/samsung/common/multi_i2c.c
new file mode 100644
index 0000000..d8d59fb
--- /dev/null
+++ b/board/samsung/common/multi_i2c.c
@@ -0,0 +1,55 @@ 
+/*
+ *  Copyright (C) 2012 Samsung Electronics
+ *  Lukasz Majewski <l.majewski@samsung.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <i2c.h>
+
+/* Handle multiple I2C buses instances */
+int get_multi_scl_pin(void)
+{
+	switch (I2C_GET_BUS()) {
+	case I2C_0:
+		return CONFIG_SOFT_I2C_I2C0_SCL;
+	case I2C_1:
+		return CONFIG_SOFT_I2C_I2C1_SCL;
+	};
+
+	return 0;
+}
+
+int get_multi_sda_pin(void)
+{
+	switch (I2C_GET_BUS()) {
+	case I2C_0:
+		return CONFIG_SOFT_I2C_I2C0_SDA;
+	case I2C_1:
+		return CONFIG_SOFT_I2C_I2C1_SDA;
+	};
+
+	return 0;
+}
+
+int multi_i2c_init(void)
+{
+	return 0;
+}
diff --git a/include/i2c.h b/include/i2c.h
index 1f35acf..00a3933 100644
--- a/include/i2c.h
+++ b/include/i2c.h
@@ -250,4 +250,15 @@  static inline void I2C_SET_BUS(unsigned int bus)
 		i2c_set_bus_num(bus);
 }
 
+/* Multi I2C busses handling */
+#ifdef CONFIG_SOFT_I2C_MULTI_BUS
+enum {
+	I2C_0,
+	I2C_1,
+};
+
+extern int get_multi_scl_pin(void);
+extern int get_multi_sda_pin(void);
+extern int multi_i2c_init(void);
+#endif
 #endif	/* _I2C_H_ */