From patchwork Mon Sep 3 14:07:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 181367 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E372B2C0090 for ; Tue, 4 Sep 2012 00:07:29 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1347286050; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=2nEyWxO bmVK+WDk+PF6WpCZdBJ0=; b=tDRG9PWLFXODVgekqphbM2JfZlk6vuJobOPEPPi aMvAIu/MfiP1lABthifdrkt5clbnkcCxCCMHB2qrUU7ij8MRhaYmTvPdsjxhExiS N0cvetZedXApaESpi2iItkk/H96ILbz4vxaE7MbdxkiIo4d30Y5zaXWVwKpi4/NR PrqQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=ILz/PqIFNi/AtFxcxf8wMAoM4ZOwd4jEVCpS0WHrEaZOVaUQuratorSb5T0CuJ CxXBp39P+MJzJQezkYqsjXwxwhcwwj/ihfUyIIPOGRjB+++W3hfUYFjyydoSKpuD jL4hzeUC2I3jn8dHGmI5c8m8JIMOUNW8wiChH9TcS6yX4=; Received: (qmail 8879 invoked by alias); 3 Sep 2012 14:07:23 -0000 Received: (qmail 8779 invoked by uid 22791); 3 Sep 2012 14:07:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Sep 2012 14:07:06 +0000 Received: from [192.168.178.22] (port-92-204-67-8.dynamic.qsc.de [92.204.67.8]) by mx01.qsc.de (Postfix) with ESMTP id 6DD163D0DE; Mon, 3 Sep 2012 16:07:04 +0200 (CEST) Message-ID: <5044B988.1030502@net-b.de> Date: Mon, 03 Sep 2012 16:07:04 +0200 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: gcc patches , gfortran Subject: [Patch, Fortran, committed] Fix PR54467 (TBP ICEs due to _final wrapper disabling) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Committed as obvious (Rev. 190892). My patch which disabled the generation of the FINAL wrapper subroutine cut out too much, namely also normal type-bound procedures. Fixed by the obvious patch. (The wrapper is currently disabled as it would be an ABI changing patch; the current plan is to enable it once the complete FINAL implementation is ready - and use a .mod version update to effectively force a recompilation.) Tobias Index: ChangeLog =================================================================== --- ChangeLog (Revision 190888) +++ ChangeLog (Arbeitskopie) @@ -1,5 +1,11 @@ 2012-09-03 Tobias Burnus + PR fortran/54467 + * class.c (gfc_find_derived_vtab): Fix disabling of _final + by continuing to generate normal type-bound procedures. + +2012-09-03 Tobias Burnus + * class.c (gfc_find_derived_vtab): Disable ABI-breaking generation of the "_final" subroutine for now. Index: class.c =================================================================== --- class.c (Revision 190888) +++ class.c (Arbeitskopie) @@ -1634,10 +1634,10 @@ gfc_find_derived_vtab (gfc_symbol *derived) c->tb = XCNEW (gfc_typebound_proc); c->tb->ppc = 1; generate_finalization_wrapper (derived, ns, tname, c); + } /* Add procedure pointers for type-bound procedures. */ add_procs_to_declared_vtab (derived, vtype); - } } have_vtype: