Patchwork [v3,01/11] mtd: mtd_nandecctest: remove unnecessary srandom32() call

login
register
mail settings
Submitter Akinobu Mita
Date Sept. 3, 2012, 12:59 p.m.
Message ID <1346677206-13621-2-git-send-email-akinobu.mita@gmail.com>
Download mbox | patch
Permalink /patch/181354/
State New
Headers show

Comments

Akinobu Mita - Sept. 3, 2012, 12:59 p.m.
It is unnecessary for this driver to call srandom32() in module_init.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
No changes from previous version

 drivers/mtd/tests/mtd_nandecctest.c | 2 --
 1 file changed, 2 deletions(-)
Artem Bityutskiy - Sept. 4, 2012, 9:46 a.m.
On Mon, 2012-09-03 at 21:59 +0900, Akinobu Mita wrote:
> It is unnecessary for this driver to call srandom32() in module_init.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Just FYI, patches 1 and 2 are already in l2-mtd.git, no need to re-send
patches which are in the l2 tree again.

Patch

diff --git a/drivers/mtd/tests/mtd_nandecctest.c b/drivers/mtd/tests/mtd_nandecctest.c
index 70d6d7d..4d7b171 100644
--- a/drivers/mtd/tests/mtd_nandecctest.c
+++ b/drivers/mtd/tests/mtd_nandecctest.c
@@ -66,8 +66,6 @@  static int nand_ecc_test(const size_t size)
 
 static int __init ecc_test_init(void)
 {
-	srandom32(jiffies);
-
 	nand_ecc_test(256);
 	nand_ecc_test(512);