Patchwork [PATCH-v2,spice,1/2] Set a8 capability in the QXL device if supported by the client

login
register
mail settings
Submitter Søren Sandmann Pedersen
Date Sept. 2, 2012, 9:35 p.m.
Message ID <1346621726-11313-5-git-send-email-ssp@redhat.com>
Download mbox | patch
Permalink /patch/181294/
State New
Headers show

Comments

Søren Sandmann Pedersen - Sept. 2, 2012, 9:35 p.m.
---
 server/red_worker.c | 2 ++
 spice-common        | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
Alon Levy - Sept. 3, 2012, 7:34 a.m.
> ---
>  server/red_worker.c | 2 ++
>  spice-common        | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 843f559..23f3464 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -10377,6 +10377,8 @@ static void
> handle_new_display_channel(RedWorker *worker, RedClient *client, Red
>              SET_CAP(caps, SPICE_DISPLAY_CAP_MONITORS_CONFIG);
>          if (red_channel_client_test_remote_cap(rcc,
>          SPICE_DISPLAY_CAP_COMPOSITE))
>              SET_CAP(caps, SPICE_DISPLAY_CAP_COMPOSITE);
> +        if (red_channel_client_test_remote_cap(rcc,
> SPICE_DISPLAY_CAP_COMPOSITE))
> +            SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE);

Didn't you mean to test remote SPICE_DISPLAY_CAP_A8_SURFACE?

>  
>          worker->qxl->st->qif->set_client_capabilities(worker->qxl,
>          TRUE, caps);
>      }
> diff --git a/spice-common b/spice-common
> index 86e286b..04dc2be 160000
> --- a/spice-common
> +++ b/spice-common
> @@ -1 +1 @@
> -Subproject commit 86e286ba2003c206e700fd70ec67c1cf4ac8d8a6
> +Subproject commit 04dc2bee9ecdda7d7966f9267df37ab23bb5a802
> --
> 1.7.11.4
> 
> 
>
Søren Sandmann - Sept. 3, 2012, 5:33 p.m.
Alon Levy <alevy@redhat.com> writes:

>> ---
>>  server/red_worker.c | 2 ++
>>  spice-common        | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/server/red_worker.c b/server/red_worker.c
>> index 843f559..23f3464 100644
>> --- a/server/red_worker.c
>> +++ b/server/red_worker.c
>> @@ -10377,6 +10377,8 @@ static void
>> handle_new_display_channel(RedWorker *worker, RedClient *client, Red
>>              SET_CAP(caps, SPICE_DISPLAY_CAP_MONITORS_CONFIG);
>>          if (red_channel_client_test_remote_cap(rcc,
>>          SPICE_DISPLAY_CAP_COMPOSITE))
>>              SET_CAP(caps, SPICE_DISPLAY_CAP_COMPOSITE);
>> +        if (red_channel_client_test_remote_cap(rcc,
>> SPICE_DISPLAY_CAP_COMPOSITE))
>> +            SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE);
>
> Didn't you mean to test remote SPICE_DISPLAY_CAP_A8_SURFACE?

Yes, good catch. I'll fix before pushing.

Thanks,
Soren
Søren Sandmann - Sept. 3, 2012, 5:49 p.m.
Søren Sandmann <sandmann@cs.au.dk> writes:

> Alon Levy <alevy@redhat.com> writes:
>
>>> ---
>>>  server/red_worker.c | 2 ++
>>>  spice-common        | 2 +-
>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/server/red_worker.c b/server/red_worker.c
>>> index 843f559..23f3464 100644
>>> --- a/server/red_worker.c
>>> +++ b/server/red_worker.c
>>> @@ -10377,6 +10377,8 @@ static void
>>> handle_new_display_channel(RedWorker *worker, RedClient *client, Red
>>>              SET_CAP(caps, SPICE_DISPLAY_CAP_MONITORS_CONFIG);
>>>          if (red_channel_client_test_remote_cap(rcc,
>>>          SPICE_DISPLAY_CAP_COMPOSITE))
>>>              SET_CAP(caps, SPICE_DISPLAY_CAP_COMPOSITE);
>>> +        if (red_channel_client_test_remote_cap(rcc,
>>> SPICE_DISPLAY_CAP_COMPOSITE))
>>> +            SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE);
>>
>> Didn't you mean to test remote SPICE_DISPLAY_CAP_A8_SURFACE?
>
> Yes, good catch. I'll fix before pushing.

I realized that I didn't actually send the whole patch series for
spice-server. There are five patches rather than two.


Soren

Patch

diff --git a/server/red_worker.c b/server/red_worker.c
index 843f559..23f3464 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -10377,6 +10377,8 @@  static void handle_new_display_channel(RedWorker *worker, RedClient *client, Red
             SET_CAP(caps, SPICE_DISPLAY_CAP_MONITORS_CONFIG);
         if (red_channel_client_test_remote_cap(rcc, SPICE_DISPLAY_CAP_COMPOSITE))
             SET_CAP(caps, SPICE_DISPLAY_CAP_COMPOSITE);
+        if (red_channel_client_test_remote_cap(rcc, SPICE_DISPLAY_CAP_COMPOSITE))
+            SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE);
 
         worker->qxl->st->qif->set_client_capabilities(worker->qxl, TRUE, caps);
     }
diff --git a/spice-common b/spice-common
index 86e286b..04dc2be 160000
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@ 
-Subproject commit 86e286ba2003c206e700fd70ec67c1cf4ac8d8a6
+Subproject commit 04dc2bee9ecdda7d7966f9267df37ab23bb5a802