[1/5] ext4: when resizing, do not copy gdt blocks for groups that do not have them

Submitted by Theodore Ts'o on Sept. 2, 2012, 4:51 a.m.


Message ID 1346561485-6413-2-git-send-email-tytso@mit.edu
State Superseded, archived
Headers show

Commit Message

Theodore Ts'o Sept. 2, 2012, 4:51 a.m.
From: Yongqiang Yang <xiaoqiangnk@gmail.com>

The resize code was copying blocks at the beginning of each block
group in order to copy the superblock and block group descriptor table
(gdt) blocks.  This was, unfortunately, being done even for block
groups that did not have super blocks or gdt blocks.  This is a
complete waste of perfectly good I/O bandwidth, to skip writing those
blocks for sparse bg's.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
 fs/ext4/resize.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 41f6ef6..724e250 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -451,6 +451,9 @@  static int setup_new_flex_group_blocks(struct super_block *sb,
 		gdblocks = ext4_bg_num_gdb(sb, group);
 		start = ext4_group_first_block_no(sb, group);
+		if (!ext4_bg_has_super(sb, group))
+			goto handle_itb;
 		/* Copy all of the GDT blocks into the backup in this group */
 		for (j = 0, block = start + 1; j < gdblocks; j++, block++) {
 			struct buffer_head *gdb;
@@ -493,6 +496,7 @@  static int setup_new_flex_group_blocks(struct super_block *sb,
 				goto out;
 		/* Initialize group tables of the grop @group */
 		if (!(bg_flags[i] & EXT4_BG_INODE_ZEROED))
 			goto handle_bb;