Patchwork ioh3420: Remove unreachable code

login
register
mail settings
Submitter Stefan Weil
Date Sept. 1, 2012, 10:56 a.m.
Message ID <1346496963-27422-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/181130/
State Accepted
Headers show

Comments

Stefan Weil - Sept. 1, 2012, 10:56 a.m.
Report from smatch:
hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/ioh3420.c |    1 -
 1 file changed, 1 deletion(-)
Juan Quintela - Sept. 2, 2012, 8:31 p.m.
Stefan Weil <sw@weilnetz.de> wrote:
> Report from smatch:
> hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>
Stefan Hajnoczi - Sept. 22, 2012, 3:41 p.m.
On Sat, Sep 01, 2012 at 12:56:03PM +0200, Stefan Weil wrote:
> Report from smatch:
> hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/ioh3420.c |    1 -
>  1 file changed, 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 94a537c..4d31473 100644
--- a/hw/ioh3420.c
+++ b/hw/ioh3420.c
@@ -125,7 +125,6 @@  static int ioh3420_initfn(PCIDevice *d)
     rc = pcie_chassis_add_slot(s);
     if (rc < 0) {
         goto err_pcie_cap;
-        return rc;
     }
     pcie_cap_root_init(d);
     rc = pcie_aer_init(d, IOH_EP_AER_OFFSET);