Patchwork target-i386: Allow tsc-frequency to be larger then 2.147G

login
register
mail settings
Submitter Fred Oliveira
Date Aug. 31, 2012, 12:30 p.m.
Message ID <1346416208-28004-1-git-send-email-foliveira@cloudswitch.com>
Download mbox | patch
Permalink /patch/180960/
State New
Headers show

Comments

Fred Oliveira - Aug. 31, 2012, 12:30 p.m.
The check using INT_MAX (2147483647) is wrong in this case.

Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
---
 target-i386/cpu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Don Slutz - Aug. 31, 2012, 2:04 p.m.
On 08/31/12 08:30, Fred Oliveira wrote:
> The check using INT_MAX (2147483647) is wrong in this case.
>
> Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
> ---
>   target-i386/cpu.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 423e009..cbc172e 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
>   {
>       X86CPU *cpu = X86_CPU(obj);
>       const int64_t min = 0;
> -    const int64_t max = INT_MAX;
> +    const int64_t max = INT64_MAX;
>       int64_t value;
>   
>       visit_type_int(v, &value, name, errp);
I think this a *trivial patch. Adding *qemu-trivial@nongnu.org.
    -Don Slutz
**

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 423e009..cbc172e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -846,7 +846,7 @@  static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
 {
     X86CPU *cpu = X86_CPU(obj);
     const int64_t min = 0;
-    const int64_t max = INT_MAX;
+    const int64_t max = INT64_MAX;
     int64_t value;
 
     visit_type_int(v, &value, name, errp);