Patchwork [2/2] mtd/nand/omap2: fix module loading

login
register
mail settings
Submitter Andreas Bießmann
Date Aug. 31, 2012, 11:35 a.m.
Message ID <1346412942-4015-3-git-send-email-andreas@biessmann.de>
Download mbox | patch
Permalink /patch/180954/
State New
Headers show

Comments

Andreas Bießmann - Aug. 31, 2012, 11:35 a.m.
Unloading the omap2 nand driver missed to release the memory region which will
result in not being able to request it again if one want to load the driver
later on.

This patch fixes following error when loading omap2 module after unloading:
---8<---
~ $ rmmod omap2
~ $ modprobe omap2
[   37.420928] omap2-nand: probe of omap2-nand.0 failed with error -16
~ $
--->8---

This error was introduced in 67ce04bf2746f8a1f8c2a104b313d20c63f68378 which
was the first commit of this driver.

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/nand/omap2.c |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 4cd7ac0..48f1d4e 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1387,6 +1387,7 @@  static int omap_nand_remove(struct platform_device *pdev)
 	/* Release NAND device, its internal structures and partitions */
 	nand_release(&info->mtd);
 	iounmap(info->nand.IO_ADDR_R);
+	release_mem_region(info->phys_base, NAND_IO_SIZE);
 	kfree(info);
 	return 0;
 }