From patchwork Fri Aug 31 10:57:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stigge@antcom.de X-Patchwork-Id: 180947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AC86A2C03CA for ; Fri, 31 Aug 2012 20:59:09 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T7OvD-0003Bg-EL; Fri, 31 Aug 2012 10:57:55 +0000 Received: from [2a01:4f8:101:2a4:0:bc28:b2d8:8] (helo=chuck.antcom.de) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T7Ov0-00039L-8J; Fri, 31 Aug 2012 10:57:42 +0000 Received: from [IPv6:2001:a60:f08d:1:224:81ff:fe9f:119e] (unknown [IPv6:2001:a60:f08d:1:224:81ff:fe9f:119e]) by chuck.antcom.de (Postfix) with ESMTPSA id B79041ECE010; Fri, 31 Aug 2012 10:57:37 +0000 (UTC) Message-ID: <504098A1.4050208@antcom.de> Date: Fri, 31 Aug 2012 12:57:37 +0200 From: Roland Stigge Organization: ANTCOM IT Research & Development User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: =?UTF-8?B?RXJpYyBCw6luYXJk?= Subject: Re: mxc_nand.c on mach-imx/imx53 References: <5035F84E.3000901@antcom.de> <20120829074122.GV26594@pengutronix.de> <503E3331.8050203@antcom.de> <20120829172820.43bbe68e@eb-e6520> <50407E44.5080408@antcom.de> In-Reply-To: <50407E44.5080408@antcom.de> X-Enigmail-Version: 1.4 OpenPGP: url=subkeys.pgp.net X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: Sascha Hauer , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On 08/31/2012 11:05 AM, Roland Stigge wrote: > I tried to port this on top of Sascha's patches for imx53, only for mxc v3 for now, as below. > > Unfortunately, I still get: > > ... > UnCorrectable RS-ECC Error > UnCorrectable RS-ECC Error > UnCorrectable RS-ECC Error > UnCorrectable RS-ECC Error > UnCorrectable RS-ECC Error > ... > > from mxc_nand.c's mxc_nand_correct_data_v2_v3(). Maybe there's still sth. missing in the > error correction code? With the below incremental fix, it works. :-) Thanks, Roland PS: Will you prepare a patch for l2-mtd.git? I only have an imx53, can't test the v1/v2 etc. configs. --- linux-2.6.orig/drivers/mtd/nand/mxc_nand.c +++ linux-2.6/drivers/mtd/nand/mxc_nand.c @@ -1141,14 +1141,14 @@ static void mxc_nand_command(struct mtd_ host->devtype_data->send_cmd(host, command, true); mxc_do_addr_cycle(mtd, column, page_addr); host->devtype_data->send_read_id(host); - host->buf_start = column; + host->buf_start = 0; break; case NAND_CMD_PARAM: host->devtype_data->send_cmd(host, command, true); mxc_do_addr_cycle(mtd, column, page_addr); host->devtype_data->send_read_param(host); - host->buf_start = column; + host->buf_start = 0; break; case NAND_CMD_ERASE1: