Patchwork iSCSI: We dont need to explicitely call qemu_notify_event() any more

login
register
mail settings
Submitter ronniesahlberg@gmail.com
Date Aug. 30, 2012, 11:56 p.m.
Message ID <1346370996-7691-2-git-send-email-ronniesahlberg@gmail.com>
Download mbox | patch
Permalink /patch/180884/
State New
Headers show

Comments

ronniesahlberg@gmail.com - Aug. 30, 2012, 11:56 p.m.
We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
---
 block/iscsi.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
ronniesahlberg@gmail.com - Sept. 7, 2012, 11:22 p.m.
Ping?

On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
<ronniesahlberg@gmail.com> wrote:
> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  block/iscsi.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 0b96165..355ce65 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>
>      }
>
> -    /* If we just added an event, the callback might be delayed
> -     * unless we call qemu_notify_event().
> -     */
> -    if (ev & ~iscsilun->events) {
> -        qemu_notify_event();
> -    }
>      iscsilun->events = ev;
>  }
>
> --
> 1.7.3.1
>
Paolo Bonzini - Sept. 8, 2012, 10:37 a.m.
Il 08/09/2012 01:22, ronnie sahlberg ha scritto:
> Ping?

Both are already in scsi-next, thanks!

Paolo

> On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
> <ronniesahlberg@gmail.com> wrote:
>> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>>  block/iscsi.c |    6 ------
>>  1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 0b96165..355ce65 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>>
>>      }
>>
>> -    /* If we just added an event, the callback might be delayed
>> -     * unless we call qemu_notify_event().
>> -     */
>> -    if (ev & ~iscsilun->events) {
>> -        qemu_notify_event();
>> -    }
>>      iscsilun->events = ev;
>>  }
>>
>> --
>> 1.7.3.1
>>
> 
>

Patch

diff --git a/block/iscsi.c b/block/iscsi.c
index 0b96165..355ce65 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -167,12 +167,6 @@  iscsi_set_events(IscsiLun *iscsilun)
 
     }
 
-    /* If we just added an event, the callback might be delayed
-     * unless we call qemu_notify_event().
-     */
-    if (ev & ~iscsilun->events) {
-        qemu_notify_event();
-    }
     iscsilun->events = ev;
 }