Patchwork faster random number engine

login
register
mail settings
Submitter Benjamin Kosnik
Date Aug. 30, 2012, 4:37 p.m.
Message ID <20120830093701.2eaad208@coso>
Download mbox | patch
Permalink /patch/180842/
State New
Headers show

Comments

Benjamin Kosnik - Aug. 30, 2012, 4:37 p.m.
On Wed, 29 Aug 2012 14:34:40 -0400
Ulrich Drepper <drepper@gmail.com> wrote:

> On Wed, Aug 29, 2012 at 11:43 AM, Paolo Carlini
> <paolo.carlini@oracle.com> wro
> > The substance isn't of course. But normally we don't have __gnu_cxx
> > things in the same std header. Can't we have a new ext/random and
> > put it in there? If we can separate the new code to it, I think
> > people would not even object to the target dependency, etc. In ext/
> > we are quite free to do extension / experimental work.
> 
> OK, I moved the definition to ext.  Will check in the result.

Nice! Thanks.

Here's a small patchlet to set the abi version to .18. With this,
check-abi will pass.

tested x86/linux

-benjamin
Paolo Carlini - Sept. 5, 2012, 9:53 a.m.
On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote:
> Nice! Thanks.
>
> Here's a small patchlet to set the abi version to .18. With this,
> check-abi will pass.
>
> tested x86/linux
Benjamin, is this still uncommitted? I'm seeing abi_check failing...

Thanks,
Paolo.
Paolo Carlini - Sept. 5, 2012, 10:55 a.m.
On 09/05/2012 11:53 AM, Paolo Carlini wrote:
> On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote:
>> Nice! Thanks.
>>
>> Here's a small patchlet to set the abi version to .18. With this,
>> check-abi will pass.
>>
>> tested x86/linux
> Benjamin, is this still uncommitted? I'm seeing abi_check failing...
Ok, now I see that the patch is in and a default configured build is 
fine abi-wise. Sorry about the false alarm.

If you are curious, the reason why I sent the message is that adding 
--enable-libstdcxx-time=rt (which should be more or less the default in 
the C++11 era) used not to lead to abi_check failures and it does now. 
Should look more into it...

Paolo.

Patch

2012-08-30  Benjamin Kosnik  <bkoz@redhat.com>

	* testsuite/util/testsuite_abi.cc (check_version): Add GLIBCXX_3.4.18.

diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc
index 4721ccd..a5066cc 100644
--- a/libstdc++-v3/testsuite/util/testsuite_abi.cc
+++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc
@@ -195,6 +195,7 @@  check_version(symbol& test, bool added)
       known_versions.push_back("GLIBCXX_3.4.15");
       known_versions.push_back("GLIBCXX_3.4.16");
       known_versions.push_back("GLIBCXX_3.4.17");
+      known_versions.push_back("GLIBCXX_3.4.18");
       known_versions.push_back("GLIBCXX_LDBL_3.4");
       known_versions.push_back("GLIBCXX_LDBL_3.4.7");
       known_versions.push_back("GLIBCXX_LDBL_3.4.10");
@@ -222,7 +223,7 @@  check_version(symbol& test, bool added)
 	test.version_status = symbol::incompatible;
 
       // Check that added symbols are added in the latest pre-release version.
-      bool latestp = (test.version_name == "GLIBCXX_3.4.17"
+      bool latestp = (test.version_name == "GLIBCXX_3.4.18"
 		     || test.version_name == "CXXABI_1.3.6"
 		     || test.version_name == "CXXABI_TM_1");
       if (added && !latestp)