Patchwork remove dependency on cp/parser.h from cp/lang.c

login
register
mail settings
Submitter Aaron Gray
Date Aug. 29, 2012, 11:54 a.m.
Message ID <CANkmNDcUxTK4aqaihfc8x7nkEpJeF_SYOdO2rQ6zjgvDrWL_gQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/180697/
State New
Headers show

Comments

Aaron Gray - Aug. 29, 2012, 11:54 a.m.
Just got my copyright assignment through, so here's my first GCC patch,

This is a one liner removing the unneeded dependency of cp-lang.c on
cp/parser.h. This has been tested on Linux.

Aaron
Marc Glisse - Aug. 29, 2012, 6:47 p.m.
On Wed, 29 Aug 2012, Aaron Gray wrote:

> Just got my copyright assignment through, so here's my first GCC patch,

Welcome!

> This is a one liner removing the unneeded dependency of cp-lang.c on
> cp/parser.h. This has been tested on Linux.

I think you need to attach a ChangeLog entry with every patch.

Also, dependencies are often repeated in makefiles. Is there anything to 
update with your patch? (maybe not, just asking)
Aaron Gray - Aug. 29, 2012, 7:54 p.m.
On 29 August 2012 19:47, Marc Glisse <marc.glisse@inria.fr> wrote:
>
> On Wed, 29 Aug 2012, Aaron Gray wrote:
>
>> Just got my copyright assignment through, so here's my first GCC patch,
>
>
> Welcome!

Thanks Marc !

>
>
>
>> This is a one liner removing the unneeded dependency of cp-lang.c on
>> cp/parser.h. This has been tested on Linux.
>
>
> I think you need to attach a ChangeLog entry with every patch.

Okay

>
>
> Also, dependencies are often repeated in makefiles. Is there anything to update with your patch? (maybe not, just asking)

Yes there is a dependency in cp/Make-lang.in, I will resubmit the patch soon.

--
Aaron

Patch

diff --git a/gcc/cp/cp-lang.c b/gcc/cp/cp-lang.c
index da7f1e1..5ca0b0a 100644
--- a/gcc/cp/cp-lang.c
+++ b/gcc/cp/cp-lang.c
@@ -32,7 +32,6 @@  along with GCC; see the file COPYING3.  If not see
 #include "cp-objcp-common.h"
 #include "hashtab.h"
 #include "target.h"
-#include "parser.h"

 enum c_language_kind c_language = clk_cxx;
 static void cp_init_ts (void);