Patchwork Quantal: ti-omap4 fails kernel package update

login
register
mail settings
Submitter Tim Gardner
Date Aug. 28, 2012, 7:39 p.m.
Message ID <503D1E6D.2060606@canonical.com>
Download mbox | patch
Permalink /patch/180537/
State New
Headers show

Comments

Tim Gardner - Aug. 28, 2012, 7:39 p.m.
BugLink: http://bugs.launchpad.net/bugs/1041607

Given Oliver's comments in the bug
(https://bugs.launchpad.net/ubuntu/quantal/+source/linux/+bug/1041607/comments/2)
I kind of wonder how the kernel postinst ever works, especially if
update-initramfs doesn't do anything until the hooks are run. Anyways,
attached is a patch that forces update-initramfs to generate an initrd
when called, rather then deferring until hook time. Is this the right
solution ?

rtg
Andy Whitcroft - Aug. 29, 2012, 7:08 p.m.
On Tue, Aug 28, 2012 at 01:39:25PM -0600, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/1041607
> 
> Given Oliver's comments in the bug
> (https://bugs.launchpad.net/ubuntu/quantal/+source/linux/+bug/1041607/comments/2)
> I kind of wonder how the kernel postinst ever works, especially if
> update-initramfs doesn't do anything until the hooks are run. Anyways,
> attached is a patch that forces update-initramfs to generate an initrd
> when called, rather then deferring until hook time. Is this the right
> solution ?

We appear in that case to be copying the initrd around instead of
making symbolic links.  In the normal case we use links so we do not
notice that the link destination is not yet made.  This allows regular
installs to work fine.  I suspect some of the kernel configuration is
missing, /etc/kernel-img.conf is likely missing the entries to enforce
link use.  I will follow up on the bug.

-apw

Patch

From 37c9ebd9a7ae4f8d6a873b21da4968f38b3b5e65 Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Tue, 28 Aug 2012 13:10:24 -0600
Subject: [PATCH] UBUNTU: [Config] Force update-initramfs to generate an
 initrd when called

BugLink: http://bugs.launchpad.net/bugs/1041607

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian/control-scripts/postinst |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control-scripts/postinst b/debian/control-scripts/postinst
index b6ed9f8..52140d2 100644
--- a/debian/control-scripts/postinst
+++ b/debian/control-scripts/postinst
@@ -834,7 +834,7 @@  if ($initrd) {
   if (! defined $ARGV[1] || ! $ARGV[1] || $ARGV[1] =~ m/<unknown>/og) {
     $upgrading = 0;
   }
-  my $ret = system("$ramdisk " . ($upgrading ? "-u" : "-c") . " -k " . $version . " >&2");
+  my $ret = system("INITRAMFS_TOOLS_KERNEL_HOOK=yes $ramdisk " . ($upgrading ? "-u" : "-c") . " -k " . $version . " >&2");
   $success = 1 unless $ret;
   die "Failed to create initrd image.\n" unless $success;
   if (! defined $ARGV[1] || ! $ARGV[1] || $ARGV[1] =~ m/<unknown>/og) {
-- 
1.7.9.5