Patchwork [U-Boot] mx28evk: Convert to mxs_adjust_memory_params()

login
register
mail settings
Submitter Fabio Estevam
Date Aug. 28, 2012, 7:29 p.m.
Message ID <1346182146-1154-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/180535/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Aug. 28, 2012, 7:29 p.m.
Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
missed to update mx28evk, which caused the board not to boot.

Apply the conversion so that the board can boot again.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx28evk/iomux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Marek Vasut - Aug. 28, 2012, 7:36 p.m.
Dear Fabio Estevam,

> Recent conversion from mx28_adjust_memory_params to
> mxs_adjust_memory_params missed to update mx28evk, which caused the board
> not to boot.

Oh of course ... that's an obvious flub. I'm very unhappy about the conversion 
causing such trouble! Please be more careful next time.

> Apply the conversion so that the board can boot again.

Yes,

Acked-by: Marek Vasut <marex@denx.de>

> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx28evk/iomux.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx28evk/iomux.c
> b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
> --- a/board/freescale/mx28evk/iomux.c
> +++ b/board/freescale/mx28evk/iomux.c
> @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
>  #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
>  					ADDR_PINS << 8 | APREBIT)
> 
> -void mx28_adjust_memory_params(uint32_t *dram_vals)
> +void mxs_adjust_memory_params(uint32_t *dram_vals)
>  {
>  	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
>  }

Best regards,
Marek Vasut
Marek Vasut - Aug. 28, 2012, 7:39 p.m.
Dear Marek Vasut,

> Dear Fabio Estevam,
> 
> > Recent conversion from mx28_adjust_memory_params to
> > mxs_adjust_memory_params missed to update mx28evk, which caused the board
> > not to boot.
> 
> Oh of course ... that's an obvious flub. I'm very unhappy about the
> conversion causing such trouble! Please be more careful next time.

btw. Otavio, tell me if this tortured you enough ... gotta train this, I'm not 
good at it yet, but fear, soon I'll improve ;-)

> > Apply the conversion so that the board can boot again.
> 
> Yes,
> 
> Acked-by: Marek Vasut <marex@denx.de>
> 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > 
> >  board/freescale/mx28evk/iomux.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/board/freescale/mx28evk/iomux.c
> > b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
> > --- a/board/freescale/mx28evk/iomux.c
> > +++ b/board/freescale/mx28evk/iomux.c
> > @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
> > 
> >  #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
> >  
> >  					ADDR_PINS << 8 | APREBIT)
> > 
> > -void mx28_adjust_memory_params(uint32_t *dram_vals)
> > +void mxs_adjust_memory_params(uint32_t *dram_vals)
> > 
> >  {
> >  
> >  	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
> >  
> >  }
> 
> Best regards,
> Marek Vasut

Best regards,
Marek Vasut
Otavio Salvador - Aug. 28, 2012, 9:49 p.m.
On Tue, Aug 28, 2012 at 4:36 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Fabio Estevam,
>
>> Recent conversion from mx28_adjust_memory_params to
>> mxs_adjust_memory_params missed to update mx28evk, which caused the board
>> not to boot.
>
> Oh of course ... that's an obvious flub. I'm very unhappy about the conversion
> causing such trouble! Please be more careful next time.

This was my fault; but good that Fabio has spot it fast.

>> Apply the conversion so that the board can boot again.
>
> Yes,
>
> Acked-by: Marek Vasut <marex@denx.de>
>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  board/freescale/mx28evk/iomux.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/mx28evk/iomux.c
>> b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
>> --- a/board/freescale/mx28evk/iomux.c
>> +++ b/board/freescale/mx28evk/iomux.c
>> @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
>>  #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
>>                                       ADDR_PINS << 8 | APREBIT)
>>
>> -void mx28_adjust_memory_params(uint32_t *dram_vals)
>> +void mxs_adjust_memory_params(uint32_t *dram_vals)
>>  {
>>       dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
>>  }
>
> Best regards,
> Marek Vasut
Fabio Estevam - Sept. 3, 2012, 4:47 p.m.
Hi Stefano,

On Tue, Aug 28, 2012 at 4:29 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
> missed to update mx28evk, which caused the board not to boot.
>
> Apply the conversion so that the board can boot again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Could this one be applied, please?

Without this patch, mx28evk does not boot.

Thanks,

Fabio Estevam
Stefano Babic - Sept. 3, 2012, 5:21 p.m.
On 03/09/2012 18:47, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Tue, Aug 28, 2012 at 4:29 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
>> missed to update mx28evk, which caused the board not to boot.
>>
>> Apply the conversion so that the board can boot again.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Could this one be applied, please?
> 
> Without this patch, mx28evk does not boot.

Sorry - I will merge it soon.

Cheers,
Stefano
Stefano Babic - Sept. 4, 2012, 10:04 a.m.
On 28/08/2012 21:29, Fabio Estevam wrote:
> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
> missed to update mx28evk, which caused the board not to boot.
> 
> Apply the conversion so that the board can boot again.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/freescale/mx28evk/iomux.c b/board/freescale/mx28evk/iomux.c
index 16a6d8a..ae6eda3 100644
--- a/board/freescale/mx28evk/iomux.c
+++ b/board/freescale/mx28evk/iomux.c
@@ -173,7 +173,7 @@  const iomux_cfg_t iomux_setup[] = {
 #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
 					ADDR_PINS << 8 | APREBIT)
 
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
 {
 	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
 }