From patchwork Tue Aug 28 13:05:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 180479 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 652E72C00D2 for ; Tue, 28 Aug 2012 23:05:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823Ab2H1NFT (ORCPT ); Tue, 28 Aug 2012 09:05:19 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:41398 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616Ab2H1NFR (ORCPT ); Tue, 28 Aug 2012 09:05:17 -0400 Received: by qcro28 with SMTP id o28so3325858qcr.19 for ; Tue, 28 Aug 2012 06:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=uVVO2BR88izK18/Bercw0EXMiQkgT38OGBo+9pNGghM=; b=H/wyKVEAgJAJSy0M+7G7H1JmUJlaZL84KNAMWE5F5s3ma+DziwiDDXqplVqci4qnXW GzneI5Y7fnTP27XAdylizgLkX1Y4UZFpuhD1+2NKYOAdYggu3eKRWHwDe6ADOhZ+DyYx /IuHkeVd6k+P1f4qHEeuQX2f/XKSmN4DX/BHHyIXX1NiGcYGz7CSugx2W4Pfp/1lGmK4 6GT0PmDcrkN4S73GgLOyAAskcLexwFmcv3bBCjXYLZZCWTugVMftTZfaLwvOzNpLBZls aWBFeNDJY2v7s6FmCtHASwVEL5xiNNT0i2JsG1Dqi7L+DGqanyLe81zSA5MB67wVk4bM tBLA== MIME-Version: 1.0 Received: by 10.224.180.70 with SMTP id bt6mr29862539qab.91.1346159116807; Tue, 28 Aug 2012 06:05:16 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Tue, 28 Aug 2012 06:05:16 -0700 (PDT) Date: Tue, 28 Aug 2012 21:05:16 +0800 Message-ID: Subject: [PATCH] tipc: remove pointless conditional before kfree_skb() From: Wei Yongjun To: jon.maloy@ericsson.com, allan.stephens@windriver.com, davem@davemloft.net Cc: yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Remove pointless conditional before kfree_skb(). Signed-off-by: Wei Yongjun --- net/tipc/port.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/tipc/port.c b/net/tipc/port.c index 07c42fb..9227d2c 100644 --- a/net/tipc/port.c +++ b/net/tipc/port.c @@ -770,8 +770,7 @@ static void port_dispatcher_sigh(void *dummy) break; } } - if (buf) - kfree_skb(buf); + kfree_skb(buf); buf = next; continue; err: @@ -819,8 +818,7 @@ err: break; } } - if (buf) - kfree_skb(buf); + kfree_skb(buf); buf = next; continue; reject: