| Message ID | 1346147802-4720-1-git-send-email-otavio@ossystems.com.br |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Dear Otavio Salvador, > Align the SSP clock speed with oscilator to achieve higher transfer > stability. This change is still pointless, unless you have user for this! > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > --- > Changes in v2: > - reword commit log to match the change description done on m28evk. > > board/freescale/mx28evk/mx28evk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/freescale/mx28evk/mx28evk.c > b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 > --- a/board/freescale/mx28evk/mx28evk.c > +++ b/board/freescale/mx28evk/mx28evk.c > @@ -49,8 +49,8 @@ int board_early_init_f(void) > > /* SSP0 clock at 96MHz */ > mx28_set_sspclk(MXC_SSPCLK0, 96000, 0); > - /* SSP2 clock at 96MHz */ > - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0); > + /* SSP2 clock at 160MHz */ > + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0); > > #ifdef CONFIG_CMD_USB > mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT); Best regards, Marek Vasut
On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut <marek.vasut@gmail.com> wrote: > Dear Otavio Salvador, > >> Align the SSP clock speed with oscilator to achieve higher transfer >> stability. > > This change is still pointless, unless you have user for this! As far as I know the SPI flash uses SSP2; so it is a user of it. >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> >> --- >> Changes in v2: >> - reword commit log to match the change description done on m28evk. >> >> board/freescale/mx28evk/mx28evk.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/board/freescale/mx28evk/mx28evk.c >> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 >> --- a/board/freescale/mx28evk/mx28evk.c >> +++ b/board/freescale/mx28evk/mx28evk.c >> @@ -49,8 +49,8 @@ int board_early_init_f(void) >> >> /* SSP0 clock at 96MHz */ >> mx28_set_sspclk(MXC_SSPCLK0, 96000, 0); >> - /* SSP2 clock at 96MHz */ >> - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0); >> + /* SSP2 clock at 160MHz */ >> + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0); >> >> #ifdef CONFIG_CMD_USB >> mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT); > > Best regards, > Marek Vasut
Dear Otavio Salvador, > On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut <marek.vasut@gmail.com> wrote: > > Dear Otavio Salvador, > > > >> Align the SSP clock speed with oscilator to achieve higher transfer > >> stability. > > > > This change is still pointless, unless you have user for this! > > As far as I know the SPI flash uses SSP2; so it is a user of it. So, why dont you also align the default clockspeed of the spi flash attached to ssp2 in the config file within this patch? Lemme answer myself after taking a look ... because that's already done. Ok, Acked-by: Marek Vasut <marex@denx.de> > >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > >> --- > >> Changes in v2: > >> - reword commit log to match the change description done on m28evk. > >> > >> board/freescale/mx28evk/mx28evk.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/board/freescale/mx28evk/mx28evk.c > >> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 > >> --- a/board/freescale/mx28evk/mx28evk.c > >> +++ b/board/freescale/mx28evk/mx28evk.c > >> @@ -49,8 +49,8 @@ int board_early_init_f(void) > >> > >> /* SSP0 clock at 96MHz */ > >> mx28_set_sspclk(MXC_SSPCLK0, 96000, 0); > >> > >> - /* SSP2 clock at 96MHz */ > >> - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0); > >> + /* SSP2 clock at 160MHz */ > >> + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0); > >> > >> #ifdef CONFIG_CMD_USB > >> > >> mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT); > > > > Best regards, > > Marek Vasut Best regards, Marek Vasut
On 28/08/2012 11:56, Otavio Salvador wrote: > Align the SSP clock speed with oscilator to achieve higher transfer > stability. > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -49,8 +49,8 @@ int board_early_init_f(void) /* SSP0 clock at 96MHz */ mx28_set_sspclk(MXC_SSPCLK0, 96000, 0); - /* SSP2 clock at 96MHz */ - mx28_set_sspclk(MXC_SSPCLK2, 96000, 0); + /* SSP2 clock at 160MHz */ + mx28_set_sspclk(MXC_SSPCLK2, 160000, 0); #ifdef CONFIG_CMD_USB mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Align the SSP clock speed with oscilator to achieve higher transfer stability. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- Changes in v2: - reword commit log to match the change description done on m28evk. board/freescale/mx28evk/mx28evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)