From patchwork Mon Aug 27 18:22:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 180263 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D70082C00BE for ; Tue, 28 Aug 2012 04:23:35 +1000 (EST) Received: from localhost ([::1]:38586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63yH-0001na-Ux for incoming@patchwork.ozlabs.org; Mon, 27 Aug 2012 14:23:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63xa-0008Jg-Ak for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T63xX-0004D6-EU for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:22:50 -0400 Received: from afflict.kos.to ([92.243.29.197]:33823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63xX-0004Cn-7U for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:22:47 -0400 Received: from kos.to (a91-156-57-9.elisa-laajakaista.fi [91.156.57.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by afflict.kos.to (Postfix) with ESMTPSA id B434B264D4 for ; Mon, 27 Aug 2012 20:22:45 +0200 (CEST) Received: from voipio (uid 1000) (envelope-from voipio@kos.to) id 5e01cf by kos.to (DragonFly Mail Agent); Mon, 27 Aug 2012 21:22:44 +0300 From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Mon, 27 Aug 2012 21:22:43 +0300 Message-Id: <097b8cb840a31ec526cc58778bd8cbab0d2beaaa.1346088997.git.riku.voipio@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 92.243.29.197 Cc: Peter Maydell Subject: [Qemu-devel] [PATCH 3/3] linux-user: Clarify "Unable to reserve guest address space" error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Maydell Now that we default to reserving nearly 4GB of RAM for the guest address space when running a 32 bit linux-user guest on 64 bit hosts, users are much more likely to run into it. Reword the message to be more informative about what failed and provide suggestions for how to fix things. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index b1c228a..1a1c661 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3519,7 +3519,10 @@ int main(int argc, char **argv, char **envp) guest_base = init_guest_space(guest_base, reserved_va, 0, have_guest_base); if (guest_base == (unsigned long)-1) { - fprintf(stderr, "Unable to reserve guest address space\n"); + fprintf(stderr, "Unable to reserve 0x%lx bytes of virtual address " + "space for use as guest address space (check your virtual " + "memory ulimit setting or reserve less using -R option)\n", + reserved_va); exit(1); }