Patchwork imx21ads : avoid overlapping static i/o mappings

login
register
mail settings
Submitter Jaccon Bastiaansen
Date Aug. 26, 2012, 9:35 p.m.
Message ID <1346016938-28175-1-git-send-email-jaccon.bastiaansen@gmail.com>
Download mbox | patch
Permalink /patch/180092/
State New
Headers show

Comments

Jaccon Bastiaansen - Aug. 26, 2012, 9:35 p.m.
The static I/O mappings for the cs89x0 ethernet controller and the
secondary AHB port 1 (SAHB1) overlapped, causing a kernel crash
at startup. This is fixed by mapping the cs89x0 to 0xf6000000 (which
is free to use according to arch/arm/plat-mxc/include/mach/hardware.h).

Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
---
 arch/arm/mach-imx/mach-mx21ads.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Sascha Hauer - Aug. 28, 2012, 6:47 a.m.
On Sun, Aug 26, 2012 at 11:35:38PM +0200, Jaccon Bastiaansen wrote:
> The static I/O mappings for the cs89x0 ethernet controller and the
> secondary AHB port 1 (SAHB1) overlapped, causing a kernel crash
> at startup. This is fixed by mapping the cs89x0 to 0xf6000000 (which
> is free to use according to arch/arm/plat-mxc/include/mach/hardware.h).
> 
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
> ---
>  arch/arm/mach-imx/mach-mx21ads.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx21ads.c b/arch/arm/mach-imx/mach-mx21ads.c
> index ed22e3f..712c90e 100644
> --- a/arch/arm/mach-imx/mach-mx21ads.c
> +++ b/arch/arm/mach-imx/mach-mx21ads.c
> @@ -31,7 +31,7 @@
>  /*
>   * Memory-mapped I/O on MX21ADS base board
>   */
> -#define MX21ADS_MMIO_BASE_ADDR   0xf5000000
> +#define MX21ADS_MMIO_BASE_ADDR   0xf6000000

I would prefer to ioremap the region instead. This makes sure this
problem is solved once and for all.

Sascha

Patch

diff --git a/arch/arm/mach-imx/mach-mx21ads.c b/arch/arm/mach-imx/mach-mx21ads.c
index ed22e3f..712c90e 100644
--- a/arch/arm/mach-imx/mach-mx21ads.c
+++ b/arch/arm/mach-imx/mach-mx21ads.c
@@ -31,7 +31,7 @@ 
 /*
  * Memory-mapped I/O on MX21ADS base board
  */
-#define MX21ADS_MMIO_BASE_ADDR   0xf5000000
+#define MX21ADS_MMIO_BASE_ADDR   0xf6000000
 #define MX21ADS_MMIO_SIZE        0xc00000
 
 #define MX21ADS_REG_ADDR(offset)    (void __force __iomem *) \