Patchwork mtd: m25p80: add support for the EON EN25Q64 chip

login
register
mail settings
Submitter Gabor Juhos
Date Aug. 26, 2012, 8:37 a.m.
Message ID <1345970251-2029-1-git-send-email-juhosg@openwrt.org>
Download mbox | patch
Permalink /patch/180031/
State New
Headers show

Comments

Gabor Juhos - Aug. 26, 2012, 8:37 a.m.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
 drivers/mtd/devices/m25p80.c |    1 +
 1 file changed, 1 insertion(+)
Artem Bityutskiy - Aug. 29, 2012, 11:04 a.m.
On Sun, 2012-08-26 at 10:37 +0200, Gabor Juhos wrote:
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> ---
>  drivers/mtd/devices/m25p80.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 5d0d68c..d812552 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -638,6 +638,7 @@ static const struct spi_device_id m25p_ids[] = {
>  	{ "en25p32", INFO(0x1c2016, 0, 64 * 1024,  64, 0) },
>  	{ "en25q32b", INFO(0x1c3016, 0, 64 * 1024,  64, 0) },
>  	{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
> +	{ "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },

I've already pushed a similar patch from "John Crispin
<blogic@openwrt.org>", but it did not have "SECT_4K". So I am not
picking this one.
John Crispin - Aug. 29, 2012, 11:13 a.m.
On 29/08/12 13:04, Artem Bityutskiy wrote:
> On Sun, 2012-08-26 at 10:37 +0200, Gabor Juhos wrote:
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>> ---
>>  drivers/mtd/devices/m25p80.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
>> index 5d0d68c..d812552 100644
>> --- a/drivers/mtd/devices/m25p80.c
>> +++ b/drivers/mtd/devices/m25p80.c
>> @@ -638,6 +638,7 @@ static const struct spi_device_id m25p_ids[] = {
>>  	{ "en25p32", INFO(0x1c2016, 0, 64 * 1024,  64, 0) },
>>  	{ "en25q32b", INFO(0x1c3016, 0, 64 * 1024,  64, 0) },
>>  	{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
>> +	{ "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
> I've already pushed a similar patch from "John Crispin
> <blogic@openwrt.org>", but it did not have "SECT_4K". So I am not
> picking this one.
>

Hi Artem,

the patch is based on this ticket ->
https://dev.openwrt.org/ticket/12077

i verified it against the datasheet. the datasheet indicates that
SECT_4K should work, but as the patch was only runtime tested without
the SECT_4K i did not add it.

Gabor told me that the SECT_4K was runtime tested on the en25q32 which
is from the same family.

I have put the submitter of  patch in CC, maybe he can test with the
SECT_4K set.

Thanks,
John

Patch

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 5d0d68c..d812552 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -638,6 +638,7 @@  static const struct spi_device_id m25p_ids[] = {
 	{ "en25p32", INFO(0x1c2016, 0, 64 * 1024,  64, 0) },
 	{ "en25q32b", INFO(0x1c3016, 0, 64 * 1024,  64, 0) },
 	{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
+	{ "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
 
 	/* Everspin */
 	{ "mr25h256", CAT25_INFO(  32 * 1024, 1, 256, 2) },