[Revised] skip gcc.target/i386/asm-dialect-1.c on darwin

Submitted by Jack Howarth on Aug. 24, 2012, 2:32 p.m.

Details

Message ID 20120824143229.GA15772@bromo.med.uc.edu
State New
Headers show

Commit Message

Jack Howarth Aug. 24, 2012, 2:32 p.m.
Currently the new gcc.target/i386/asm-dialect-1.c testcase is failing on
darwin due the absence of support for -masm=intel on that target. The attached
patch skips this test on darwin. Tested on x86_64-apple-darwin12...

http://gcc.gnu.org/ml/gcc-testresults/2012-08/msg02042.html

Okay for gcc trunk?
              Jack


2012-08-24  Jack Howarth  <howarth@bromo.med.uc.edu>

	PR target/54255 
	* gcc.target/i386/asm-dialect-1.c: Skip on darwin.

Comments

Rainer Orth Aug. 24, 2012, 3:02 p.m.
Jack Howarth <howarth@bromo.med.uc.edu> writes:

> ===================================================================
> --- gcc/testsuite/gcc.target/i386/asm-dialect-1.c	(revision 190647)
> +++ gcc/testsuite/gcc.target/i386/asm-dialect-1.c	(working copy)
> @@ -1,4 +1,5 @@
>  /* { dg-options "-masm=intel" } */
> +/* { dg-skip-if "No support for -masm=intel" { *-*-darwin* } { "*" } { "" } } */

You still explicitly list the default include-opts and exclude-opts for
dg-skip-if.  Please leave them off completely.

Thanks.
        Rainer

Patch hide | download patch | download mbox

Index: gcc/testsuite/gcc.target/i386/asm-dialect-1.c
warth@bromo ~]$ vi 

===================================================================
--- gcc/testsuite/gcc.target/i386/asm-dialect-1.c	(revision 190647)
+++ gcc/testsuite/gcc.target/i386/asm-dialect-1.c	(working copy)
@@ -1,4 +1,5 @@ 
 /* { dg-options "-masm=intel" } */
+/* { dg-skip-if "No support for -masm=intel" { *-*-darwin* } { "*" } { "" } } */
 
 extern void abort (void);