Patchwork [06/10] qom: expose object_property_del_child

login
register
mail settings
Submitter pingfan liu
Date Aug. 24, 2012, 9:49 a.m.
Message ID <1345801763-24227-7-git-send-email-qemulist@gmail.com>
Download mbox | patch
Permalink /patch/179819/
State New
Headers show

Comments

pingfan liu - Aug. 24, 2012, 9:49 a.m.
From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>

qmp and qdev need it.

Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
 include/qemu/object.h |    3 +++
 qom/object.c          |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)
Paolo Bonzini - Aug. 24, 2012, 2:44 p.m.
Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> 
> qmp and qdev need it.
> 
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
>  include/qemu/object.h |    3 +++
>  qom/object.c          |    2 +-
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/include/qemu/object.h b/include/qemu/object.h
> index 7cc3ebb..0142da4 100644
> --- a/include/qemu/object.h
> +++ b/include/qemu/object.h
> @@ -914,6 +914,9 @@ Object *object_resolve_path_component(Object *parent, gchar *part);
>  void object_property_add_child(Object *obj, const char *name,
>                                 Object *child, struct Error **errp);
>  
> +void object_property_del_child(Object *obj, Object *child,
> +                                struct Error **errp);
> +
>  /**
>   * object_property_add_link:
>   * @obj: the object to add a property to
> diff --git a/qom/object.c b/qom/object.c
> index be460df..6c90cfa 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -345,7 +345,7 @@ static void object_property_del_all(Object *obj)
>      }
>  }
>  
> -static void object_property_del_child(Object *obj, Object *child, Error **errp)
> +void object_property_del_child(Object *obj, Object *child, Error **errp)
>  {
>      ObjectProperty *prop;
>  
> 

Not needed, see my reply to patch 9.

Paolo

Patch

diff --git a/include/qemu/object.h b/include/qemu/object.h
index 7cc3ebb..0142da4 100644
--- a/include/qemu/object.h
+++ b/include/qemu/object.h
@@ -914,6 +914,9 @@  Object *object_resolve_path_component(Object *parent, gchar *part);
 void object_property_add_child(Object *obj, const char *name,
                                Object *child, struct Error **errp);
 
+void object_property_del_child(Object *obj, Object *child,
+                                struct Error **errp);
+
 /**
  * object_property_add_link:
  * @obj: the object to add a property to
diff --git a/qom/object.c b/qom/object.c
index be460df..6c90cfa 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -345,7 +345,7 @@  static void object_property_del_all(Object *obj)
     }
 }
 
-static void object_property_del_child(Object *obj, Object *child, Error **errp)
+void object_property_del_child(Object *obj, Object *child, Error **errp)
 {
     ObjectProperty *prop;