diff mbox

[U-Boot,2/2] dfu:usb:fix: Read the "filesize" environment variable only when file read

Message ID 1345800836-15573-2-git-send-email-l.majewski@samsung.com
State Accepted
Commit 81c1d7b605e1a48d3c02248c5e51fabcf42f5014
Headers show

Commit Message

Łukasz Majewski Aug. 24, 2012, 9:33 a.m. UTC 
The "filesize" environment variable shall be read only when relevant
file is read.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/dfu/dfu_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Marek Vasut Aug. 24, 2012, 2:31 p.m. UTC | #1 
Dear Lukasz Majewski,

> The "filesize" environment variable shall be read only when relevant
> file is read.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/dfu/dfu_mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
> index 2270a61..5d504df 100644
> --- a/drivers/dfu/dfu_mmc.c
> +++ b/drivers/dfu/dfu_mmc.c
> @@ -89,7 +89,7 @@ static int mmc_file_op(enum dfu_mmc_op op, struct
> dfu_entity *dfu, return ret;
>  	}
> 
> -	if (dfu->layout != DFU_RAW_ADDR) {
> +	if (dfu->layout != DFU_RAW_ADDR && op == DFU_OP_READ) {
>  		str_env = getenv("filesize");
>  		if (str_env == NULL) {
>  			puts("dfu: Wrong file size!\n");

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
index 2270a61..5d504df 100644
--- a/drivers/dfu/dfu_mmc.c
+++ b/drivers/dfu/dfu_mmc.c
@@ -89,7 +89,7 @@  static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu,
 		return ret;
 	}
 
-	if (dfu->layout != DFU_RAW_ADDR) {
+	if (dfu->layout != DFU_RAW_ADDR && op == DFU_OP_READ) {
 		str_env = getenv("filesize");
 		if (str_env == NULL) {
 			puts("dfu: Wrong file size!\n");