Patchwork powerpc: dts: 52xx: drop critical IRQ from dts files

login
register
mail settings
Submitter Wolfram Sang
Date Aug. 23, 2012, 3:31 p.m.
Message ID <1345735866-10001-1-git-send-email-w.sang@pengutronix.de>
Download mbox | patch
Permalink /patch/179674/
State Rejected
Delegated to: Anatolij Gustschin
Headers show

Comments

Wolfram Sang - Aug. 23, 2012, 3:31 p.m.
The wakeup-gpios have been assigned a critical IRQ in current
devicetrees. The PIC driver does not support critical IRQs, though, which
leads to the following error when booting (a PCM030 in this case):

	mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
	irq: irq-16==>hwirq-0x3 mapping failed: -22
	[WARNing skipped]

Remove these entries until they are supported, if ever.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: John Bonesio <bones@secretlab.ca>
Cc: Anatolij Gustschin <agust@denx.de>
---
 arch/powerpc/boot/dts/lite5200.dts  |    2 +-
 arch/powerpc/boot/dts/mpc5200b.dtsi |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Grant Likely - Aug. 23, 2012, 3:59 p.m.
On Thu, Aug 23, 2012 at 4:31 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> The wakeup-gpios have been assigned a critical IRQ in current
> devicetrees. The PIC driver does not support critical IRQs, though, which
> leads to the following error when booting (a PCM030 in this case):
>
>         mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
>         irq: irq-16==>hwirq-0x3 mapping failed: -22
>         [WARNing skipped]
>
> Remove these entries until they are supported, if ever.

The warning is a bug since the irq specifier is valid. Removing the
irqs from the .dts files isn't the solution.

g.

>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: John Bonesio <bones@secretlab.ca>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
>  arch/powerpc/boot/dts/lite5200.dts  |    2 +-
>  arch/powerpc/boot/dts/mpc5200b.dtsi |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
> index 179a178..25adace 100644
> --- a/arch/powerpc/boot/dts/lite5200.dts
> +++ b/arch/powerpc/boot/dts/lite5200.dts
> @@ -141,7 +141,7 @@
>                 gpio@c00 {
>                         compatible = "fsl,mpc5200-gpio-wkup";
>                         reg = <0xc00 0x40>;
> -                       interrupts = <1 8 0 0 3 0>;
> +                       interrupts = <1 8 0>;
>                         gpio-controller;
>                         #gpio-cells = <2>;
>                 };
> diff --git a/arch/powerpc/boot/dts/mpc5200b.dtsi b/arch/powerpc/boot/dts/mpc5200b.dtsi
> index 7ab286a..e610d68 100644
> --- a/arch/powerpc/boot/dts/mpc5200b.dtsi
> +++ b/arch/powerpc/boot/dts/mpc5200b.dtsi
> @@ -141,7 +141,7 @@
>                 gpio_wkup: gpio@c00 {
>                         compatible = "fsl,mpc5200b-gpio-wkup","fsl,mpc5200-gpio-wkup";
>                         reg = <0xc00 0x40>;
> -                       interrupts = <1 8 0 0 3 0>;
> +                       interrupts = <1 8 0>;
>                         gpio-controller;
>                         #gpio-cells = <2>;
>                 };
> --
> 1.7.10.4
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
Wolfram Sang - Aug. 24, 2012, 8:44 a.m.
On Thu, Aug 23, 2012 at 04:59:26PM +0100, Grant Likely wrote:
> On Thu, Aug 23, 2012 at 4:31 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > The wakeup-gpios have been assigned a critical IRQ in current
> > devicetrees. The PIC driver does not support critical IRQs, though, which
> > leads to the following error when booting (a PCM030 in this case):
> >
> >         mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
> >         irq: irq-16==>hwirq-0x3 mapping failed: -22
> >         [WARNing skipped]
> >
> > Remove these entries until they are supported, if ever.
> 
> The warning is a bug since the irq specifier is valid. Removing the
> irqs from the .dts files isn't the solution.

Adding another warning (not error) that critical IRQ are not supported
is?

Patch

diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
index 179a178..25adace 100644
--- a/arch/powerpc/boot/dts/lite5200.dts
+++ b/arch/powerpc/boot/dts/lite5200.dts
@@ -141,7 +141,7 @@ 
 		gpio@c00 {
 			compatible = "fsl,mpc5200-gpio-wkup";
 			reg = <0xc00 0x40>;
-			interrupts = <1 8 0 0 3 0>;
+			interrupts = <1 8 0>;
 			gpio-controller;
 			#gpio-cells = <2>;
 		};
diff --git a/arch/powerpc/boot/dts/mpc5200b.dtsi b/arch/powerpc/boot/dts/mpc5200b.dtsi
index 7ab286a..e610d68 100644
--- a/arch/powerpc/boot/dts/mpc5200b.dtsi
+++ b/arch/powerpc/boot/dts/mpc5200b.dtsi
@@ -141,7 +141,7 @@ 
 		gpio_wkup: gpio@c00 {
 			compatible = "fsl,mpc5200b-gpio-wkup","fsl,mpc5200-gpio-wkup";
 			reg = <0xc00 0x40>;
-			interrupts = <1 8 0 0 3 0>;
+			interrupts = <1 8 0>;
 			gpio-controller;
 			#gpio-cells = <2>;
 		};