From patchwork Thu Aug 23 13:26:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 179651 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7DCC42C00B7 for ; Thu, 23 Aug 2012 23:27:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933103Ab2HWN1V (ORCPT ); Thu, 23 Aug 2012 09:27:21 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:39327 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933870Ab2HWN1R (ORCPT ); Thu, 23 Aug 2012 09:27:17 -0400 Received: by wibhr14 with SMTP id hr14so945258wib.1 for ; Thu, 23 Aug 2012 06:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=2o8HqQlojDGxrgQpnorq9/00llyKc04vYZx1Sv/0m3M=; b=Gx90QD2aC/PV/aR9s4Op06fNFIbZozY6gpls2VkzT+EODCz7BXzoyBjvR+wGaDuMQC pbCPyED3QUr6L3L+bZheOyEDl5zJj2aDrxLo9/qgIE1cUlaenV/EXHyGp/HHBfAJefEt 4o11ge0TIJWbjTNX2ctVv7EyeHc+ILnvDOTrSOfkgY8mXnD1jjuv5jqdFDsHd69tW4w6 0uEd/mZyw2YA1P1iZo+rsLU047zxmdSzoqEnmdg2jJldbwZKiRFmtS06u2dXl3teK5xX v+63V9Z3BWctsBx6vGCz6uACZz1qEGzA6L5m0gGBvQIcITRcfO9UF5yatEQwcFSXxswG Hjzw== Received: by 10.216.134.11 with SMTP id r11mr753754wei.177.1345728436509; Thu, 23 Aug 2012 06:27:16 -0700 (PDT) Received: from localhost (sun-0.pirko.cz. [84.16.102.25]) by mx.google.com with ESMTPS id l6sm44811124wiz.4.2012.08.23.06.27.06 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 06:27:11 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, brouer@redhat.com, ogerlitz@mellanox.com Subject: [patch net-next 1/3] teamd: don't print warn message on -ESRCH during event send Date: Thu, 23 Aug 2012 15:26:51 +0200 Message-Id: <1345728413-10298-2-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1345728413-10298-1-git-send-email-jiri@resnulli.us> References: <1345728413-10298-1-git-send-email-jiri@resnulli.us> X-Gm-Message-State: ALoCoQkSbpq0j6TsSDvhPjCewbStrYCRxtd/cUelXWbfhL/4mYx/i4Kcmc58muNq6hu3IQeqpvLn Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When no one is listening on NL socket, -ESRCH is returned and warning message is printed. This message is confusing people and in fact has no meaning. So do not print it in this case. Reported-by: Or Gerlitz Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 17ce11b..4010bcd 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2487,7 +2487,7 @@ static void __team_options_change_check(struct team *team) list_add_tail(&opt_inst->tmp_list, &sel_opt_inst_list); } err = team_nl_send_event_options_get(team, &sel_opt_inst_list); - if (err) + if (err && err != -ESRCH) netdev_warn(team->dev, "Failed to send options change via netlink (err %d)\n", err); } @@ -2518,9 +2518,9 @@ static void __team_port_change_check(struct team_port *port, bool linkup) send_event: err = team_nl_send_event_port_list_get(port->team); - if (err) - netdev_warn(port->team->dev, "Failed to send port change of device %s via netlink\n", - port->dev->name); + if (err && err != -ESRCH) + netdev_warn(port->team->dev, "Failed to send port change of device %s via netlink (err %d)\n", + port->dev->name, err); }