Patchwork hso driver fix for big endian machines.

login
register
mail settings
Submitter Denis Joseph Barrow
Date Jan. 12, 2009, 2:59 p.m.
Message ID <496B5ABE.2060406@option.com>
Download mbox | patch
Permalink /patch/17960/
State Accepted
Delegated to: David Miller
Headers show

Comments

Denis Joseph Barrow - Jan. 12, 2009, 2:59 p.m.
Hi there,
This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
Filip Aben says this fix is neccessary for big endian machines.

If anybody has one & a hso device & a big endian machine I'd greatly appreciate if you tell me if this
patch works.


A patch needed to make the hso driver work on big endian machines.
Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
---
Oliver Neukum - Jan. 12, 2009, 3:04 p.m.
Am Monday 12 January 2009 15:59:10 schrieb Denis Joseph Barrow:
> This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
> Filip Aben says this fix is neccessary for big endian machines.

He's correct. They are needed.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Jan. 13, 2009, 5:56 a.m.
From: Oliver Neukum <oliver@neukum.org>
Date: Mon, 12 Jan 2009 16:04:40 +0100

> Am Monday 12 January 2009 15:59:10 schrieb Denis Joseph Barrow:
> > This patch is against 2.6.29-rc1 I hope it'll apply to other trees if neccessary.
> > Filip Aben says this fix is neccessary for big endian machines.
> 
> He's correct. They are needed.

Patch applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

A patch needed to make the hso driver work on big endian machines.
Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
---
Index: linux-2.6/drivers/net/usb/hso.c
===================================================================
--- linux-2.6.orig/drivers/net/usb/hso.c	2009-01-12 15:49:57.000000000 +0100
+++ linux-2.6/drivers/net/usb/hso.c	2009-01-12 15:50:33.000000000 +0100
@@ -1792,8 +1792,8 @@ 
 
 	/* initialize */
 	ctrl_req->wValue = 0;
-	ctrl_req->wIndex = hso_port_to_mux(port);
-	ctrl_req->wLength = size;
+	ctrl_req->wIndex = cpu_to_le16(hso_port_to_mux(port));
+	ctrl_req->wLength = cpu_to_le16(size);
 
 	if (type == USB_CDC_GET_ENCAPSULATED_RESPONSE) {
 		/* Reading command */