Patchwork [v2] ARM: imx: add imx5x usb controller clock lookups

login
register
mail settings
Submitter Michael Grzeschik
Date Aug. 23, 2012, 11:01 a.m.
Message ID <1345719696-25738-1-git-send-email-m.grzeschik@pengutronix.de>
Download mbox | patch
Permalink /patch/179599/
State New
Headers show

Comments

Michael Grzeschik - Aug. 23, 2012, 11:01 a.m.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 arch/arm/mach-imx/clk-imx51-imx53.c |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
Fabio Estevam - Aug. 23, 2012, 11:13 a.m.
Hi Michael,

On Thu, Aug 23, 2012 at 8:01 AM, Michael Grzeschik
<m.grzeschik@pengutronix.de> wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  arch/arm/mach-imx/clk-imx51-imx53.c |   24 ++++++++++++++++++++++++

Just curious: does the current Chip Idea USB driver work 'as is' on mx5?

Are you also going to submit the <soc>.dtsi and <board>.dts patches?

I would like to try it on a mx53qsb.

Regards,

Fabio Estevam
Michael Grzeschik - Aug. 23, 2012, 11:36 a.m.
Hi Fabio,

On Thu, Aug 23, 2012 at 08:13:38AM -0300, Fabio Estevam wrote:
> On Thu, Aug 23, 2012 at 8:01 AM, Michael Grzeschik
> <m.grzeschik@pengutronix.de> wrote:
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> >  arch/arm/mach-imx/clk-imx51-imx53.c |   24 ++++++++++++++++++++++++
> 
> Just curious: does the current Chip Idea USB driver work 'as is' on mx5?

Not "as is" but we are working on it to get all patches for that
mainline. Currently there is the static CI13XXX_REQUIRE_TRANSCEIVER flag
in the ci13xxx_imx_data, which makes the socs with no real xceiver
depend on the nop-xceiver. But that one lags clk_prepare_{enable, disable}.
But we already prepared that in some, "hopefully ready for mainline", patches.

> Are you also going to submit the <soc>.dtsi and <board>.dts patches?

Yes, the dtsi patch is alread on the list:
http://www.spinics.net/lists/arm-kernel/msg190737.html

> I would like to try it on a mx53qsb.

we got it already running with that board and the above mentioned
dependencies.

Cheers,

Michael
Fabio Estevam - Aug. 23, 2012, 11:54 a.m.
Hi Michael,

On Thu, Aug 23, 2012 at 8:36 AM, Michael Grzeschik <mgr@pengutronix.de> wrote:

> we got it already running with that board and the above mentioned
> dependencies.

This is very good news. I will wait for the patches to reach the
mainling lists and then will have a try.

Thanks,

Fabio Estevam

Patch

diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
index 4bdcaa9..7eba6ab 100644
--- a/arch/arm/mach-imx/clk-imx51-imx53.c
+++ b/arch/arm/mach-imx/clk-imx51-imx53.c
@@ -351,6 +351,18 @@  int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
 	clk_register_clkdev(clk[ipu_di0_gate], "di0", "imx51-ipu");
 	clk_register_clkdev(clk[ipu_di1_gate], "di1", "imx51-ipu");
 	clk_register_clkdev(clk[ipu_gate], "hsp", "imx51-ipu");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80600.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80600.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80600.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80400.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80400.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80400.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80200.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80200.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80200.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
 	clk_register_clkdev(clk[usb_phy_gate], "phy", "mxc-ehci.0");
 	clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx51.0");
 	clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx51.0");
@@ -439,6 +451,18 @@  int __init mx53_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
 	clk_register_clkdev(clk[ipu_di0_gate], "di0", "imx53-ipu");
 	clk_register_clkdev(clk[ipu_di1_gate], "di1", "imx53-ipu");
 	clk_register_clkdev(clk[ipu_gate], "hsp", "imx53-ipu");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80600.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80600.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80600.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80400.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80400.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80400.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80200.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80200.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80200.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80000.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80000.usb");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80000.usb");
 	clk_register_clkdev(clk[usb_phy1_gate], "usb_phy1", "mxc-ehci.0");
 	clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx53.0");
 	clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx53.0");