Patchwork [1/2] PPC: e500: increase DTC_LOAD_PAD

login
register
mail settings
Submitter Scott Wood
Date Aug. 23, 2012, 12:55 a.m.
Message ID <1345683341-8236-1-git-send-email-scottwood@freescale.com>
Download mbox | patch
Permalink /patch/179475/
State New
Headers show

Comments

Scott Wood - Aug. 23, 2012, 12:55 a.m.
An allowance of 5 MiB for BSS is not enough for Linux kernels with certain
debug options enabled (not sure exactly which one caused it, but I'd guess
lockdep).  The kernel I ran into this with had a BSS of around 6.4 MB.

Unfortunately, uImage does not give us enough information to determine the
actual BSS size.  Increase the allowance to 18 MiB to give us plenty of
room.  Eventually this should be more intelligent, possibly packing
initrd+dtb at the end of guest RAM.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 hw/ppc/e500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alexander Graf - Sept. 25, 2012, 7:47 a.m.
On 23.08.2012, at 02:55, Scott Wood wrote:

> An allowance of 5 MiB for BSS is not enough for Linux kernels with certain
> debug options enabled (not sure exactly which one caused it, but I'd guess
> lockdep).  The kernel I ran into this with had a BSS of around 6.4 MB.
> 
> Unfortunately, uImage does not give us enough information to determine the
> actual BSS size.  Increase the allowance to 18 MiB to give us plenty of
> room.  Eventually this should be more intelligent, possibly packing
> initrd+dtb at the end of guest RAM.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>

Thanks, applied to ppc-next.


Alex

> ---
> hw/ppc/e500.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index 6f0de6d..1ccfd7c 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -36,7 +36,7 @@
> 
> #define BINARY_DEVICE_TREE_FILE    "mpc8544ds.dtb"
> #define UIMAGE_LOAD_BASE           0
> -#define DTC_LOAD_PAD               0x500000
> +#define DTC_LOAD_PAD               0x1800000
> #define DTC_PAD_MASK               0xFFFFF
> #define INITRD_LOAD_PAD            0x2000000
> #define INITRD_PAD_MASK            0xFFFFFF
> -- 
> 1.7.9.5
> 
>

Patch

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 6f0de6d..1ccfd7c 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -36,7 +36,7 @@ 
 
 #define BINARY_DEVICE_TREE_FILE    "mpc8544ds.dtb"
 #define UIMAGE_LOAD_BASE           0
-#define DTC_LOAD_PAD               0x500000
+#define DTC_LOAD_PAD               0x1800000
 #define DTC_PAD_MASK               0xFFFFF
 #define INITRD_LOAD_PAD            0x2000000
 #define INITRD_PAD_MASK            0xFFFFFF