Patchwork Add some MTRR specific klog tests.

login
register
mail settings
Submitter Colin King
Date Aug. 22, 2012, 4:51 p.m.
Message ID <1345654317-7735-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/179349/
State Accepted
Headers show

Comments

Colin King - Aug. 22, 2012, 4:51 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
Alex Hung - Aug. 23, 2012, 7:54 a.m.
On 08/23/2012 12:51 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index a1f6c62..653b592 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -825,6 +825,20 @@
>     },
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_BIOS",
> +   "pattern": "mtrr:.*no more MTRRs available",
> +   "advice": "A device driver has tried to allocate a Memory Type Range Register (MTRR) to optimially configure a caching policy on a memory region but there are no more free MTRRs available.  Generally the firmware should allow for one or two free MTRRs for drivers to allocate.  The system will have a sub-optimally configured memory region and this may severely impact on performance."
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_BIOS",
> +   "pattern":  "[drm].*MTRR allocation failed.*Graphics performance may suffer",
> +   "advice": "The DRM driver has tried to allocate a Memory Type Range Register (MTRR) but there are no more free MTRRs available. The system will have a sub-optimally configured graphics memory region and this may severely impact on graphics rendering throughput and performance.  The firmware should allow for one or two free MTRRs, but it hasn't, which is probably a firmware bug."
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_MEDIUM",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "mtrr:.*your BIOS has configured an incorrect mask, fixing it",
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu - Aug. 24, 2012, 6:05 a.m.
On 08/23/2012 12:51 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index a1f6c62..653b592 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -825,6 +825,20 @@
>     },
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_BIOS",
> +   "pattern": "mtrr:.*no more MTRRs available",
> +   "advice": "A device driver has tried to allocate a Memory Type Range Register (MTRR) to optimially configure a caching policy on a memory region but there are no more free MTRRs available.  Generally the firmware should allow for one or two free MTRRs for drivers to allocate.  The system will have a sub-optimally configured memory region and this may severely impact on performance."
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_BIOS",
> +   "pattern":  "[drm].*MTRR allocation failed.*Graphics performance may suffer",
> +   "advice": "The DRM driver has tried to allocate a Memory Type Range Register (MTRR) but there are no more free MTRRs available. The system will have a sub-optimally configured graphics memory region and this may severely impact on graphics rendering throughput and performance.  The firmware should allow for one or two free MTRRs, but it hasn't, which is probably a firmware bug."
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_MEDIUM",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "mtrr:.*your BIOS has configured an incorrect mask, fixing it",
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index a1f6c62..653b592 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -825,6 +825,20 @@ 
   },
   {
    "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_BIOS",
+   "pattern": "mtrr:.*no more MTRRs available",
+   "advice": "A device driver has tried to allocate a Memory Type Range Register (MTRR) to optimially configure a caching policy on a memory region but there are no more free MTRRs available.  Generally the firmware should allow for one or two free MTRRs for drivers to allocate.  The system will have a sub-optimally configured memory region and this may severely impact on performance."
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_BIOS",
+   "pattern":  "[drm].*MTRR allocation failed.*Graphics performance may suffer",
+   "advice": "The DRM driver has tried to allocate a Memory Type Range Register (MTRR) but there are no more free MTRRs available. The system will have a sub-optimally configured graphics memory region and this may severely impact on graphics rendering throughput and performance.  The firmware should allow for one or two free MTRRs, but it hasn't, which is probably a firmware bug."
+  },
+  {
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_MEDIUM",
    "tag": "FWTS_TAG_BIOS",
    "pattern": "mtrr:.*your BIOS has configured an incorrect mask, fixing it",