Patchwork [i4l] minor cleanups

login
register
mail settings
Submitter Paul Bolle
Date Jan. 12, 2009, 12:37 p.m.
Message ID <1231763858.7132.8.camel@test.thuisdomein>
Download mbox | patch
Permalink /patch/17931/
State Accepted
Delegated to: David Miller
Headers show

Comments

Paul Bolle - Jan. 12, 2009, 12:37 p.m.
Minor cleanups, either made possible or obvious after commit d700555 (I4l:
convert to net_device_ops).

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Sent only to netdev@vger.kernel.org (and not also to
isdn4linux@listserv.isdn4linux.de) because an earlier ISDN patch I wrote
only got a response from this list (and this patch is NETWORKING related
anyway).
---


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Jan. 14, 2009, 10:42 p.m.
From: Paul Bolle <pebolle@tiscali.nl>
Date: Mon, 12 Jan 2009 13:37:38 +0100

> Minor cleanups, either made possible or obvious after commit d700555 (I4l:
> convert to net_device_ops).
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
index 7c5f970..ecc92c8 100644
--- a/drivers/isdn/i4l/isdn_net.c
+++ b/drivers/isdn/i4l/isdn_net.c
@@ -2513,7 +2513,6 @@  static const struct net_device_ops isdn_netdev_ops = {
 	.ndo_stop	      = isdn_net_close,
 	.ndo_do_ioctl	      = isdn_net_ioctl,
 
-	.ndo_validate_addr    = NULL,
 	.ndo_start_xmit	      = isdn_net_start_xmit,
 	.ndo_get_stats	      = isdn_net_get_stats,
 	.ndo_tx_timeout	      = isdn_net_tx_timeout,
@@ -2528,12 +2527,8 @@  static void _isdn_setup(struct net_device *dev)
 
 	ether_setup(dev);
 
-	dev->flags = IFF_NOARP | IFF_POINTOPOINT;
 	/* Setup the generic properties */
-	dev->mtu = 1500;
 	dev->flags = IFF_NOARP|IFF_POINTOPOINT;
-	dev->type = ARPHRD_ETHER;
-	dev->addr_len = ETH_ALEN;
 	dev->header_ops = NULL;
 	dev->netdev_ops = &isdn_netdev_ops;