From patchwork Wed Aug 22 11:16:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Terry Guo X-Patchwork-Id: 179300 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 13E642C0094 for ; Wed, 22 Aug 2012 21:15:15 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1346238916; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=edgMWjDwVDVF5lkqf38J9YdEYqY=; b=rdFLzFMKXs3NMGm1FN6S1ohS33mJtCHn7iHE2ZdIlQubBlCXdh4MOuZ31HI7kO FiGoWVLVc6qI9t2AE1dFADOzDhkzrmZjwcbzih+z1StS1tK18rSiuOSNO/B9MPhO B/8gGvpdbxlf//Y8gCJnMN2wTaIZZKBnmZBCv4EJn2LJA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:X-MC-Unique:Content-Type:Content-Transfer-Encoding:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Kvoa13F0vL5i+QGcafoBlYxXirHTTAGPFi3rx5arbvO/idfM65Zw0REKwuNWUH +PqqPTiyktmGYOLZVJGSWjsHDB1g48DG7/3c/nSL1gWP7E/JSPDIU/Ws+0XtL5Ut nPhjemIxnU9EFlvigxYYXhmRVzzVvSGHK31l5h0KWmS28=; Received: (qmail 7440 invoked by alias); 22 Aug 2012 11:15:01 -0000 Received: (qmail 7431 invoked by uid 22791); 22 Aug 2012 11:14:59 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 11:14:28 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 22 Aug 2012 12:14:26 +0100 Received: from shawin053 ([10.164.2.89]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 22 Aug 2012 12:16:16 +0100 From: "Terry Guo" To: "Richard Earnshaw" Cc: References: <000001cd8004$485ab0e0$d91012a0$@guo@arm.com> <5034AF05.2090905@arm.com> In-Reply-To: <5034AF05.2090905@arm.com> Subject: RE: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode Date: Wed, 22 Aug 2012 19:16:14 +0800 Message-ID: <000401cd8057$8d1b0240$a75106c0$@guo@arm.com> MIME-Version: 1.0 X-MC-Unique: 112082212142607601 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > > > > Due to the impact of ARM UAL, the Thumb1 and Thumb2 mode use LSRS > > instruction while the ARM mode uses MOVS instruction. So the > following case > > is updated accordingly. Is it OK to trunk? > > > > BR, > > Terry > > > > 2012-08-21 Terry Guo > > > > * gcc.target/arm/combine-movs.c: Check movs for ARM mode > > and lsrs for other mode. > > > > This can't be right. Thumb1 doesn't use unified syntax. > > R. > oops. You are right. Sorry for making such obvious mistake. Here is patch updated to distinguish ARM and Thumb2. Tested for Thumb1, Thumb2 and ARM modes. No regression. Is it OK? BR, Terry 2012-08-21 Terry Guo * gcc.target/arm/combine-movs.c: Check movs for ARM mode and lsrs for Thumb2 mode. +/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target { ! arm_thumb2_ok } } } } */ diff --git a/gcc/testsuite/gcc.target/arm/combine-movs.c b/gcc/testsuite/gcc.target/arm/combine-movs.c index 4209a33..3e36033 100644 --- a/gcc/testsuite/gcc.target/arm/combine-movs.c +++ b/gcc/testsuite/gcc.target/arm/combine-movs.c @@ -9,4 +9,5 @@ void foo (unsigned long r[], unsigned int d) r[i] = 0; } -/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */ +/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target arm_thumb2_ok } } } */