From patchwork Wed Aug 22 03:02:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pingfan liu X-Patchwork-Id: 179221 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 774E22C0090 for ; Wed, 22 Aug 2012 13:03:08 +1000 (EST) Received: from localhost ([::1]:55670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T41Dl-0007jL-4a for incoming@patchwork.ozlabs.org; Tue, 21 Aug 2012 23:03:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T41Dd-0007jG-SN for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T41Dc-0005KD-To for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:57 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:65320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T41Dc-0005K5-PN for qemu-devel@nongnu.org; Tue, 21 Aug 2012 23:02:56 -0400 Received: by yenm4 with SMTP id m4so399996yen.4 for ; Tue, 21 Aug 2012 20:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=9KpaW99QpXuYgyGVPlY0XGefJ2FYh3/XYiz2pzJ3E0M=; b=fYXIFwA1Fx9BXLen/RrH5ALt1sd026UJiyEZG6SB9Z7TcHHajZB0vh1oIKAnuH+D+2 G7HbDgGn99SXJyfzTzvrct+3Q40XMk1SP3eLUw9qwCLbZdar/hDsN4JQD9kIbKqDqL0h n3Pzb3N36wbW3FB710FQoen2A8o/C94yH5BZhOZJkEyfcG0kEOrOIHtjNaRqksH4a2rP 5oyWJO6hcil7WO/VEU+dWR4JoAjvDnEj+DUjV7kGabigCnic1fOWc0SBko7zrPO34u4k y4qwBq1M/EbupnVr8rH54F7uZ95h5+f7X93V6llczuPKmVmUbj9jlJRtuVnwwojWJlKx n0mw== Received: by 10.60.20.74 with SMTP id l10mr14370766oee.19.1345604576138; Tue, 21 Aug 2012 20:02:56 -0700 (PDT) Received: from localhost ([221.223.240.75]) by mx.google.com with ESMTPS id bp7sm2885083obc.12.2012.08.21.20.02.51 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Aug 2012 20:02:55 -0700 (PDT) From: Liu Ping Fan To: qemu-devel@nongnu.org Date: Wed, 22 Aug 2012 11:02:42 +0800 Message-Id: <1345604562-27289-1-git-send-email-qemulist@gmail.com> X-Mailer: git-send-email 1.7.4.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.213.173 Cc: Liu Ping Fan , Anthony Liguori Subject: [Qemu-devel] [PATCH] qom: removal of link property need to release its target X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Liu Ping Fan Currently, link property's target is only managed by object_set_link_property(). This will raise such issue that when the property is finalized, its target has no opportunity to release. Fix this issue by introduce object_finalize_link_property() Signed-off-by: Liu Ping Fan Acked-by: Paolo Bonzini --- qom/object.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/qom/object.c b/qom/object.c index a552be2..76b3d34 100644 --- a/qom/object.c +++ b/qom/object.c @@ -957,6 +957,16 @@ static void object_set_link_property(Object *obj, Visitor *v, void *opaque, } } +static void object_finalize_link_property(Object *obj, const char *name, + void *opaque) +{ + Object **child = opaque; + + if (*child != NULL) { + object_unref(*child); + } +} + void object_property_add_link(Object *obj, const char *name, const char *type, Object **child, Error **errp) @@ -968,7 +978,7 @@ void object_property_add_link(Object *obj, const char *name, object_property_add(obj, name, full_type, object_get_link_property, object_set_link_property, - NULL, child, errp); + object_finalize_link_property, child, errp); g_free(full_type); }