From patchwork Tue Aug 21 20:19:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,3/7] UBI: accept empty string for vid_hdr_offs parameter Date: Tue, 21 Aug 2012 10:19:33 -0000 From: Shmulik Ladkani X-Patchwork-Id: 179157 Message-Id: <20120821231933.722f5be4@halley> To: dedekind1@gmail.com Cc: Richard Genoud , linux-mtd@lists.infradead.org On Mon, 20 Aug 2012 16:04:58 +0300 Artem Bityutskiy wrote: > Please, let's not over-engineer this, do not bother with ",,", use ",0," > instead. Just do amend the documentation properly. Artem, you are probably right, but it was really a one-liner: But either case, I guess the user will probably still need to take a look at the description to understand how to "avoid specifying" the vid_hdr_offs ;-) So no real benefit supporting ",," Bit more intuitive, though. Anyways, saw you already pushed, thanks. Shmulik diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 2c5ed5c..1745764 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1333,7 +1333,7 @@ static int __init ubi_mtd_param_parse(const char *val, struct kernel_param *kp) p = &mtd_dev_param[mtd_devs]; strcpy(&p->name[0], tokens[0]); - if (tokens[1]) + if (tokens[1] && *tokens[1] != '\0') p->vid_hdr_offs = bytes_str_to_int(tokens[1]); if (p->vid_hdr_offs < 0)