Patchwork [v2,3/7] UBI: accept empty string for vid_hdr_offs parameter

login
register
mail settings
Submitter Shmulik Ladkani
Date Aug. 21, 2012, 8:19 p.m.
Message ID <20120821231933.722f5be4@halley>
Download mbox | patch
Permalink /patch/179157/
State New
Headers show

Comments

Shmulik Ladkani - Aug. 21, 2012, 8:19 p.m.
On Mon, 20 Aug 2012 16:04:58 +0300 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> Please, let's not over-engineer this, do not bother with ",,", use ",0,"
> instead. Just do amend the documentation properly.

Artem, you are probably right, but it was really a one-liner:



But either case, I guess the user will probably still need to take a
look at the description to understand how to "avoid specifying" the
vid_hdr_offs ;-)
So no real benefit supporting ",,"
Bit more intuitive, though.

Anyways, saw you already pushed, thanks.

Shmulik
Artem Bityutskiy - Aug. 22, 2012, 8:51 a.m.
On Tue, 2012-08-21 at 23:19 +0300, Shmulik Ladkani wrote:
> But either case, I guess the user will probably still need to take a
> look at the description to understand how to "avoid specifying" the
> vid_hdr_offs ;-)
> So no real benefit supporting ",,"

We have 0 as the default value already, no need to have the second way
to specify the same.

Patch

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 2c5ed5c..1745764 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1333,7 +1333,7 @@  static int __init ubi_mtd_param_parse(const char *val, struct kernel_param *kp)
 	p = &mtd_dev_param[mtd_devs];
 	strcpy(&p->name[0], tokens[0]);
 
-	if (tokens[1])
+	if (tokens[1] && *tokens[1] != '\0')
 		p->vid_hdr_offs = bytes_str_to_int(tokens[1]);
 
 	if (p->vid_hdr_offs < 0)