From patchwork Tue Aug 21 18:18:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: libata-core: use ATA_LBA in ata_build_rw_tf() Date: Tue, 21 Aug 2012 08:18:50 -0000 From: Sergei Shtylyov X-Patchwork-Id: 179131 Message-Id: <201208212218.51059.sshtylyov@ru.mvista.com> To: linux-ide@vger.kernel.org, jgarzik@pobox.com Since READ/WRITE FPDMA QUEUED commands are 48-bit, bit 6 of the device register means LBA, the same as for READ/WRITE DMA EXT commands. So use ATA_LBA instead of the bare number in ata_build_rw_tf()'s branch dedicated to the NCQ commands. Signed-off-by: Sergei Shtylyov --- The patch is atop of the 'upstream' branch of libata-dev.git... drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: libata-dev/drivers/ata/libata-core.c =================================================================== --- libata-dev.orig/drivers/ata/libata-core.c +++ libata-dev/drivers/ata/libata-core.c @@ -774,7 +774,7 @@ int ata_build_rw_tf(struct ata_taskfile tf->lbam = (block >> 8) & 0xff; tf->lbal = block & 0xff; - tf->device = 1 << 6; + tf->device = ATA_LBA; if (tf->flags & ATA_TFLAG_FUA) tf->device |= 1 << 7; } else if (dev->flags & ATA_DFLAG_LBA) {