Patchwork libata-core: use ATA_LBA in ata_build_rw_tf()

login
register
mail settings
Submitter Sergei Shtylyov
Date Aug. 21, 2012, 6:18 p.m.
Message ID <201208212218.51059.sshtylyov@ru.mvista.com>
Download mbox | patch
Permalink /patch/179131/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sergei Shtylyov - Aug. 21, 2012, 6:18 p.m.
Since READ/WRITE FPDMA QUEUED commands are 48-bit, bit 6 of the device register
means LBA, the same as for READ/WRITE DMA EXT commands. So use ATA_LBA instead
of the bare number in ata_build_rw_tf()'s branch dedicated to the NCQ commands.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
The patch is atop of the 'upstream' branch of libata-dev.git...

 drivers/ata/libata-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: libata-dev/drivers/ata/libata-core.c
===================================================================
--- libata-dev.orig/drivers/ata/libata-core.c
+++ libata-dev/drivers/ata/libata-core.c
@@ -774,7 +774,7 @@  int ata_build_rw_tf(struct ata_taskfile 
 		tf->lbam = (block >> 8) & 0xff;
 		tf->lbal = block & 0xff;
 
-		tf->device = 1 << 6;
+		tf->device = ATA_LBA;
 		if (tf->flags & ATA_TFLAG_FUA)
 			tf->device |= 1 << 7;
 	} else if (dev->flags & ATA_DFLAG_LBA) {