Patchwork misc: remove old crufty valgrind script

login
register
mail settings
Submitter Colin King
Date Aug. 21, 2012, 3:40 p.m.
Message ID <1345563624-3991-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/179079/
State Accepted
Headers show

Comments

Colin King - Aug. 21, 2012, 3:40 p.m.
From: Colin Ian King <colin.king@canonical.com>

Remove an old crufty valgrind script that's been around for way
too long and isn't being used now for regression testing.  We should
instead add some wider valgrind testing in fwts-test instead. For now
just remove this.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 regression/valgrind.sh |   31 -------------------------------
 1 file changed, 31 deletions(-)
 delete mode 100755 regression/valgrind.sh
Alex Hung - Aug. 23, 2012, 2:16 a.m.
On 08/21/2012 11:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove an old crufty valgrind script that's been around for way
> too long and isn't being used now for regression testing.  We should
> instead add some wider valgrind testing in fwts-test instead. For now
> just remove this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   regression/valgrind.sh |   31 -------------------------------
>   1 file changed, 31 deletions(-)
>   delete mode 100755 regression/valgrind.sh
>
> diff --git a/regression/valgrind.sh b/regression/valgrind.sh
> deleted file mode 100755
> index 56f8fca..0000000
> --- a/regression/valgrind.sh
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -#!/bin/bash
> -fwts=../src/fwts
> -
> -run_arg_tests()
> -{
> -	echo Test: $1
> -	sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $1 2>&1 | grep "ERROR SUMMARY:"
> -}
> -
> -run_tests()
> -{
> -	tests=`fwts --show-tests | grep -v "Available tests" | awk '{ print $1'}`
> -	for test in $tests
> -	do
> -		echo Test: $test
> -		sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $test --no-s3 --no-s4 2> errors.txt
> -		grep "ERROR SUMMARY:" errors.txt
> -		rm errors.txt
> -	done
> -}
> -run_arg_tests "--dump"
> -run_arg_tests "--version"
> -run_arg_tests "--debug-output=stdout osilinux"
> -run_arg_tests "--force_clean osilinux"
> -run_arg_tests "--force_clean --results-output=/dev/null osilinux"
> -run_arg_tests "--force_clean --show-progress osilinux"
> -run_arg_tests "--force_clean --fwts-debug -progress osilinux"
> -run_arg_tests "--help"
> -
> -run_tests
> -
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu - Aug. 24, 2012, 6:04 a.m.
On 08/21/2012 11:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove an old crufty valgrind script that's been around for way
> too long and isn't being used now for regression testing.  We should
> instead add some wider valgrind testing in fwts-test instead. For now
> just remove this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   regression/valgrind.sh |   31 -------------------------------
>   1 file changed, 31 deletions(-)
>   delete mode 100755 regression/valgrind.sh
>
> diff --git a/regression/valgrind.sh b/regression/valgrind.sh
> deleted file mode 100755
> index 56f8fca..0000000
> --- a/regression/valgrind.sh
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -#!/bin/bash
> -fwts=../src/fwts
> -
> -run_arg_tests()
> -{
> -	echo Test: $1
> -	sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $1 2>&1 | grep "ERROR SUMMARY:"
> -}
> -
> -run_tests()
> -{
> -	tests=`fwts --show-tests | grep -v "Available tests" | awk '{ print $1'}`
> -	for test in $tests
> -	do
> -		echo Test: $test
> -		sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $test --no-s3 --no-s4 2> errors.txt
> -		grep "ERROR SUMMARY:" errors.txt
> -		rm errors.txt
> -	done
> -}
> -run_arg_tests "--dump"
> -run_arg_tests "--version"
> -run_arg_tests "--debug-output=stdout osilinux"
> -run_arg_tests "--force_clean osilinux"
> -run_arg_tests "--force_clean --results-output=/dev/null osilinux"
> -run_arg_tests "--force_clean --show-progress osilinux"
> -run_arg_tests "--force_clean --fwts-debug -progress osilinux"
> -run_arg_tests "--help"
> -
> -run_tests
> -
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/regression/valgrind.sh b/regression/valgrind.sh
deleted file mode 100755
index 56f8fca..0000000
--- a/regression/valgrind.sh
+++ /dev/null
@@ -1,31 +0,0 @@ 
-#!/bin/bash
-fwts=../src/fwts
-
-run_arg_tests()
-{
-	echo Test: $1
-	sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $1 2>&1 | grep "ERROR SUMMARY:"
-}
-
-run_tests()
-{
-	tests=`fwts --show-tests | grep -v "Available tests" | awk '{ print $1'}`
-	for test in $tests
-	do
-		echo Test: $test
-		sudo valgrind --leak-check=full --show-reachable=yes -v $fwts $test --no-s3 --no-s4 2> errors.txt
-		grep "ERROR SUMMARY:" errors.txt
-		rm errors.txt
-	done
-}
-run_arg_tests "--dump"
-run_arg_tests "--version"
-run_arg_tests "--debug-output=stdout osilinux"
-run_arg_tests "--force_clean osilinux"
-run_arg_tests "--force_clean --results-output=/dev/null osilinux"
-run_arg_tests "--force_clean --show-progress osilinux"
-run_arg_tests "--force_clean --fwts-debug -progress osilinux"
-run_arg_tests "--help"
-
-run_tests
-