From patchwork Tue Aug 21 14:42:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 179075 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 57A9D2C00BD for ; Wed, 22 Aug 2012 00:42:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369Ab2HUOmX (ORCPT ); Tue, 21 Aug 2012 10:42:23 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:64525 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755136Ab2HUOmT (ORCPT ); Tue, 21 Aug 2012 10:42:19 -0400 Received: by bkwj10 with SMTP id j10so2214443bkw.19 for ; Tue, 21 Aug 2012 07:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=I4P0Fgk+7QVGXnmIgJqpkNknepbYvCEHP6TBKuoQMo0=; b=P4DCyEkooNvfaZdgbJ6ZtsRiZRIp1k+fxV82Krrb06nrufD+tNVFjLI0ZnMX+77xQk vNNLQFecx3UWQlSmCwrdKrLT8Jzt+UfJliEb7p14jmdElzzgeekfb8H3sL/48kfdv+jV yAUPNJ/6YHoFccpiOus7jTLsgN7fjvwGJ8PambcJcMa/Z69cj4dRNw0T5sPS5vuR0T4y GjhQZgvkMhCP5EHiOWCJ1RIXcANMn45KUk/kMvdmkK4NfI+iomTNaXVzEIrVyskVsGbV VesHNP04jkCz7uj27bvHu956QhGT4NDj5XeFfVpERnCj6alT1VDoA+0ooLpsWJo1G61p Jo0w== Received: by 10.204.8.65 with SMTP id g1mr5399357bkg.50.1345560138436; Tue, 21 Aug 2012 07:42:18 -0700 (PDT) Received: from [172.28.91.230] ([74.125.122.49]) by mx.google.com with ESMTPS id gq2sm967268bkc.13.2012.08.21.07.42.14 (version=SSLv3 cipher=OTHER); Tue, 21 Aug 2012 07:42:15 -0700 (PDT) Subject: Re: IP fragmentation broken in 3.6-rc ? From: Eric Dumazet To: Sylvain Munaut Cc: netdev@vger.kernel.org In-Reply-To: <1345555336.5158.493.camel@edumazet-glaptop> References: <1345555336.5158.493.camel@edumazet-glaptop> Date: Tue, 21 Aug 2012 16:42:11 +0200 Message-ID: <1345560131.5158.500.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2012-08-21 at 15:22 +0200, Eric Dumazet wrote: > On Tue, 2012-08-21 at 15:05 +0200, Sylvain Munaut wrote: > > Hi, > > > > I'm starting to wonder if it's not related to > > 46517008e1168dc926cf2c47d529efc07eca85c0 "ipv4: Kill > > ip_rt_frag_needed()." > > > > Cheers, > > > > Sylvain > > Hmm, most probably problem came with commit > ceb3320610d6f15ff20dd4c042b36473d77de76f > (ipv4: Kill routes during PMTU/redirect updates.) > > Following patch should help : --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/net/dst.h b/include/net/dst.h index 621e351..a04aa37 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -435,7 +435,7 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout) if (expires == 0) expires = 1; - if (dst->expires == 0 || time_before(expires, dst->expires)) + if (dst->expires == 0 || time_after(expires, dst->expires)) dst->expires = expires; }