From patchwork Tue Aug 21 12:25:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 179053 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4ED3C2C00BB for ; Tue, 21 Aug 2012 22:22:10 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3nSD-0004XU-7y; Tue, 21 Aug 2012 12:21:05 +0000 Received: from mga11.intel.com ([192.55.52.93]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3nRU-0004Mq-Gl for linux-mtd@lists.infradead.org; Tue, 21 Aug 2012 12:20:21 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 21 Aug 2012 05:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,802,1336374000"; d="asc'?scan'208";a="207430117" Received: from linux.jf.intel.com (HELO linux.intel.com) ([10.23.232.205]) by fmsmga001.fm.intel.com with ESMTP; 21 Aug 2012 05:20:19 -0700 Received: from [10.237.72.96] (sauron.fi.intel.com [10.237.72.96]) by linux.intel.com (Postfix) with ESMTP id D73042C8001; Tue, 21 Aug 2012 05:20:18 -0700 (PDT) Message-ID: <1345551904.2848.95.camel@sauron.fi.intel.com> Subject: Re: new 3.5.2 ubifs debug assert From: Artem Bityutskiy To: MichaelHench@gmail.com Date: Tue, 21 Aug 2012 15:25:04 +0300 In-Reply-To: References: X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -5.0 (-----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-5.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.55.52.93 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dedekind1[at]gmail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (dedekind1[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list Cc: linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Mon, 2012-08-20 at 13:09 -0500, Michael Hench wrote: > apparently UBIFS debugging is always on in 3.5.2 > can anyone tell me what this means ? It should not. We use 'pr_debug()' for debugging messages, which are off by default. To enable them, you need to do something like described here: http://www.linux-mtd.infradead.org/faq/ubifs.html#L_how_debug E.g., echo 'format "UBIFS DBG" +pf' > /sys/kernel/debug/dynamic_debug/control would enable all UBIFS debugging messages. I do not know why they are switched on in your system. > UBIFS assert failed in dbg_snprintf_key at 136 (pid 28692) Hmm, strange, would be interesting to see the length in your setup. Would you try this patch: and send what that printk says? diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index bb31672..52b0290 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -133,6 +133,7 @@ const char *dbg_snprintf_key(const struct ubifs_info *c, } } else len -= snprintf(p, len, "bad key format %d", c->key_fmt); + printk(KERN_ERR "len %d, p %s\n", len, p); ubifs_assert(len > 0); return p; }