From patchwork Tue Aug 21 12:25:04 2012
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: new 3.5.2 ubifs debug assert
Date: Tue, 21 Aug 2012 02:25:04 -0000
From: Artem Bityutskiy <dedekind1@gmail.com>
X-Patchwork-Id: 179053
Message-Id: <1345551904.2848.95.camel@sauron.fi.intel.com>
To: MichaelHench@gmail.com
Cc: linux-mtd@lists.infradead.org

On Mon, 2012-08-20 at 13:09 -0500, Michael Hench wrote:
> apparently UBIFS debugging is always on in 3.5.2
> can anyone tell me what this means ?

It should not. We use 'pr_debug()' for debugging messages, which are
off by default. To enable them, you need to do something like described
here:

http://www.linux-mtd.infradead.org/faq/ubifs.html#L_how_debug

E.g.,
echo 'format "UBIFS DBG" +pf' > /sys/kernel/debug/dynamic_debug/control

would enable all UBIFS debugging messages.

I do not know why they are switched on in your system.

> UBIFS assert failed in dbg_snprintf_key at 136 (pid 28692)

Hmm, strange, would be interesting to see the length in your setup.
Would you try this patch:


and send what that printk says?


diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index bb31672..52b0290 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -133,6 +133,7 @@ const char *dbg_snprintf_key(const struct ubifs_info *c,
                }
        } else
                len -= snprintf(p, len, "bad key format %d", c->key_fmt);
+       printk(KERN_ERR "len %d, p %s\n", len, p);
        ubifs_assert(len > 0);
        return p;
 }