Patchwork new 3.5.2 ubifs debug assert

login
register
mail settings
Submitter Artem Bityutskiy
Date Aug. 21, 2012, 12:25 p.m.
Message ID <1345551904.2848.95.camel@sauron.fi.intel.com>
Download mbox | patch
Permalink /patch/179053/
State New
Headers show

Comments

Artem Bityutskiy - Aug. 21, 2012, 12:25 p.m.
On Mon, 2012-08-20 at 13:09 -0500, Michael Hench wrote:
> apparently UBIFS debugging is always on in 3.5.2
> can anyone tell me what this means ?

It should not. We use 'pr_debug()' for debugging messages, which are
off by default. To enable them, you need to do something like described
here:

http://www.linux-mtd.infradead.org/faq/ubifs.html#L_how_debug

E.g.,
echo 'format "UBIFS DBG" +pf' > /sys/kernel/debug/dynamic_debug/control

would enable all UBIFS debugging messages.

I do not know why they are switched on in your system.

> UBIFS assert failed in dbg_snprintf_key at 136 (pid 28692)

Hmm, strange, would be interesting to see the length in your setup.
Would you try this patch:


and send what that printk says?

Patch

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index bb31672..52b0290 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -133,6 +133,7 @@  const char *dbg_snprintf_key(const struct ubifs_info *c,
                }
        } else
                len -= snprintf(p, len, "bad key format %d", c->key_fmt);
+       printk(KERN_ERR "len %d, p %s\n", len, p);
        ubifs_assert(len > 0);
        return p;
 }