Patchwork [2/3] UBIFS: fix error error path

login
register
mail settings
Submitter Artem Bityutskiy
Date Aug. 21, 2012, 11:05 a.m.
Message ID <1345547160-31958-3-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/179041/
State Accepted
Commit 11e3be0be2a1314e0861304857e7efcaed5d3e54
Headers show

Comments

Artem Bityutskiy - Aug. 21, 2012, 11:05 a.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

This patch fixes a regression introduced by
"4994297 UBIFS: make ubifs_lpt_init clean-up in case of failure" which
I've hit while running the 'integck -p' test. When remount the file-system
from R/O mode to R/W mode and 'lpt_init_wr()' fails, we free _all_ LPT
resources by calling 'ubifs_lpt_free(c, 0)', even those needed for R/O
mode. This leads to subsequent crashes, e.g., if we try to unmount
the file-system.

Cc: stable@vger.kernel.org [v3.5+]
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/ubifs/lpt.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
index ce33b2b..8640920 100644
--- a/fs/ubifs/lpt.c
+++ b/fs/ubifs/lpt.c
@@ -1749,7 +1749,10 @@  int ubifs_lpt_init(struct ubifs_info *c, int rd, int wr)
 	return 0;
 
 out_err:
-	ubifs_lpt_free(c, 0);
+	if (wr)
+		ubifs_lpt_free(c, 1);
+	if (rd)
+		ubifs_lpt_free(c, 0);
 	return err;
 }