Patchwork netfilter 09/09: remove padding from struct xt_match on 64bit builds

login
register
mail settings
Submitter Patrick McHardy
Date Jan. 12, 2009, 10:06 a.m.
Message ID <20090112100611.9280.87597.sendpatchset@x2.localnet>
Download mbox | patch
Permalink /patch/17900/
State Accepted
Delegated to: David Miller
Headers show

Comments

Patrick McHardy - Jan. 12, 2009, 10:06 a.m.
commit 269e837197ecee6b37ed3d83b1ddc582f6a53947
Author: Richard Kennedy <richard@rsk.demon.co.uk>
Date:   Mon Jan 12 10:52:48 2009 +0100

    netfilter: remove padding from struct xt_match on 64bit builds
    
    reorder struct xt_match to remove 8 bytes of padding and make its size
    128 bytes.
    
    This saves a small amount of data space in each of the xt netfilter
    modules and fits xt_match in one 128 byte cache line.
    
    Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
    Signed-off-by: Patrick McHardy <kaber@trash.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
index e52ce47..c7ee874 100644
--- a/include/linux/netfilter/x_tables.h
+++ b/include/linux/netfilter/x_tables.h
@@ -270,6 +270,7 @@  struct xt_match
 	struct list_head list;
 
 	const char name[XT_FUNCTION_MAXNAMELEN-1];
+	u_int8_t revision;
 
 	/* Return true or false: return FALSE and set *hotdrop = 1 to
            force immediate packet drop. */
@@ -302,7 +303,6 @@  struct xt_match
 	unsigned short proto;
 
 	unsigned short family;
-	u_int8_t revision;
 };
 
 /* Registration hooks for targets. */