Patchwork Test 272 fails for ext3

login
register
mail settings
Submitter Jan Kara
Date Aug. 20, 2012, 4:22 p.m.
Message ID <20120820162212.GA17354@quack.suse.cz>
Download mbox | patch
Permalink /patch/178872/
State Rejected
Headers show

Comments

Jan Kara - Aug. 20, 2012, 4:22 p.m.
On Fri 17-08-12 08:48:58, Dave Chinner wrote:
> On Thu, Aug 16, 2012 at 11:37:57AM +0200, Jan Kara wrote:
> >   Hello,
> > 
> >   I was looking into why test 272 from xfstests fails for ext3 and the
> > reason is that ext3 does not support direct IO to file with enabled data
> > journalling (open returns EINVAL because ->direct_IO callback is not
> > specified). So I was thinking how to accomodate this fact in the test -
> > the best I found was to just check using xfs_io whether O_DIRECT open
> > succeeds and perform the test only in that case. Attached patch does this
> > or do people have other ideas?
> 
> 
> # ext3 doesn't support direct IO in journalling mode
> ext3_write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> ext4_write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> 
> if [ $FSTYP = "ext3" ]; then
> 	write_opt_list="$ext3_write_opt_list"
> else
> 	write_opt_list="$ext4_write_opt_list"
> fi
  Yeah, this is probably simpler. Thanks for suggestion. BTW, ext4 also
does not support direct IO and data journalling but it silently falls back
to buffered IO. Anyway new patch is attached.

								Honza

Patch

From 563edb54e3f3a45b5c92ab21bbe41deacef0ae39 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Thu, 16 Aug 2012 11:14:35 +0200
Subject: [PATCH v2] Make test 272 work for ext3

ext3 does not support direct IO for files with data journalling. This
confuses test 272. Make the test check whether open succeeds and perform
the writing only if it does.

Thanks for Dave Chinner for suggesting a simpler way to fix the test.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 272 |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/272 b/272
index 26dfa3b..7b142e2 100755
--- a/272
+++ b/272
@@ -32,6 +32,12 @@  tmp=/tmp/$$
 status=1	# failure is the default!
 trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
 
+write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
+if [ $FSTYP = "ext3" ]; then
+	# ext3 doesn't support direct IO in journalling mode
+	write_opt_list="iflag=noatime conv=notrunc conv=fsync"
+fi
+
 # get standard environment, filters and checks
 . ./common.rc
 . ./common.filter
@@ -40,7 +46,6 @@  _workout()
 	echo ""
 	echo " Switch data journalling mode"
 	echo ""
-	write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
 	chattr_opt_list="+j -j +jS -j"
 	idx=0
 	#
-- 
1.7.1